Import l10n files from mozilla-aurora #4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@yurydelendik I have made all the changes that were proposed in #3766 and properly squashed and rebased the commits. Could you check if all is right? |
… the next commit with proper language codes
yurydelendik
added a commit
that referenced
this pull request
Mar 26, 2014
Import l10n files from mozilla-aurora
|
Thank you for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3242 and supersedes #3762 and #3766. It adds a Makefile utility called
importl10n(call:node make importl10n) that fetches the latest translations from mozilla-aurora. This avoids users translating strings here that are already translated by the Firefox team and makes sure that translations are always synchronized between Firefox and PDF.js.Note that this tool keeps our
metadata.incfiles because the Firefox team does not translate those.The PR changes the regex used in
node make firefoxa bit to allow the new languages codes from mozilla-aurora, in particular three-letter codes.