-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setGStateForKey() closure. #5205
Conversation
setGStateForKey() is a closure that serves no particularly useful purpose. This change inlines it at the single call site. This avoids 1.7 MiB of allocations (because closures are objects) for the MTA map mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=835380#c17.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://107.22.172.223:8877/34890a99a5dbd64/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://107.21.233.14:8877/c07d3d7a2410c11/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/34890a99a5dbd64/output.txt Total script time: 2.99 mins
Image differences available at: http://107.22.172.223:8877/34890a99a5dbd64/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c07d3d7a2410c11/output.txt Total script time: 22.64 mins
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/ed895ecaf265982/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/f51dbe14374f895/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/f51dbe14374f895/output.txt Total script time: 20.13 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/ed895ecaf265982/output.txt Total script time: 22.69 mins
|
Remove setGStateForKey() closure.
Thank you |
setGStateForKey() is a closure that serves no particularly useful
purpose. This change inlines it at the single call site. This avoids 1.7
MiB of allocations (because closures are objects) for the MTA map
mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=835380#c17.