Replace unnecessary bind(this) and var self = this statements with arrow functions in src/core/evaluator.js
#8355
+51
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h arrow functions in `src/core/evaluator.js` Note that by using `let` instead of `var` in `PartialEvaluator.setGState` and `TranslatedFont.loadType3Data`, we can get rid of further `bind` usages since `let` is block-scoped. Also, the fact that `bind` wasn't used in the `Font` case inside of `setGState` is actually a bug which has been present ever since PR 5205, where a closure was replaced by a standard loop.[1] --- [1] I'm not aware of any bugs caused by this, but that is probably more a happy accident than anything else, since e.g. just removing the `bind` from the `SMask` case without using block-scoped variables causes test failures.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/ed32efdb84d7c80/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/aea05dced383f0a/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/aea05dced383f0a/output.txt Total script time: 20.96 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/ed32efdb84d7c80/output.txt Total script time: 32.75 mins
|
timvandermeij
approved these changes
May 1, 2017
|
Nice work! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Replace unnecessary `bind(this)` and `var self = this` statements with arrow functions in `src/core/evaluator.js`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that by using
letinstead ofvarinPartialEvaluator.setGStateandTranslatedFont.loadType3Data, we can get rid of furtherbindusages sinceletis block-scoped.Also, the fact that
bindwasn't used in theFontcase inside ofsetGStateis actually a bug which has been present ever since PR #5205, where a closure was replaced by a standard loop.[1][1] I'm not aware of any bugs caused by this, but that is probably more a happy accident than anything else, since e.g. just removing the
bindfrom theSMaskcase without using block-scoped variables causes test failures.Edit: Slightly smaller diff with https://github.com/mozilla/pdf.js/pull/8355/files?w=1.