Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch 'master' (incoming 0.13 release including haskell-lsp-0.17) #41

Merged
merged 43 commits into from
Oct 23, 2019

Conversation

jneira
Copy link

@jneira jneira commented Oct 21, 2019

No description provided.

jneira and others added 30 commits September 25, 2019 15:28
* Taking in account terms between backquote and single quote

* Add comment
Use the new key format in one line for azure cache
Add stack-install-cabal target and confirmation messages
Find and run cabal in user original $PATH
Stack 2.1.3 does not build cabal-helper properly on initial run.
and update instructions to run the build script with cabal on windows
Add instructions about install cabal with stack and update instructions to run the build script with cabal on windows in the README
alanz and others added 5 commits October 20, 2019 21:53
Together with haskell-lsp-types and lsp-test

This now supports LSP spec 3.15
brittany-0.12.1
floskell-0.10.1
hlint-2.2.3
hsimport-0.11.0
@jneira
Copy link
Author

jneira commented Oct 22, 2019

This version has 2 errors in the functional test that are not present in hie master nor the hie-bios branch(https://circleci.com/gh/jneira/haskell-ide-engine/11) :

Your job ran 109 tests with 2 failures
1. sends indefinite progress notifications - Progress.window/workDoneProgress
Received an unexpected message from the server: Was parsing: Publish diagnostics notification Last message received: ReqWorkDoneProgressCreate (RequestMessage {_jsonrpc = "2.0", _id = IdInt 0, _method = WindowWorkDoneProgressCreate, _params = WorkDoneProgressCreateParams {_token = ProgressNumericToken 0}})
2. sends indefinite progress notifications with liquid - Progress.window/workDoneProgress
NamedParserException "Logging notification" (NamedParserException "Publish diagnostics notification" (NamedParserException "Logging notification" (BothFailed (Unexpected "ConduitParser.empty") (Unexpected "ConduitParser.empty"))))

@jneira jneira force-pushed the hie-bios-haskell-lsp-0.17 branch from 198fd9c to 582ff05 Compare October 23, 2019 09:34
@jneira
Copy link
Author

jneira commented Oct 23, 2019

Ok, i've merged the lastest master commit that likely will be the 0.13 release.
I've correct the progress test case and now the test suite has the same errors than https://github.com/mpickering/haskell-ide-engine

Your job ran 142 tests with 2 failures
find type-definition of type def in component - HaRePlugin.hare plugin.Additional GHC API commands
Expected IdeResultOk [Location {_uri = Uri {getUri = "file:///root/build/test/testdata/gototest/src/Lib.hs"}, _range = Range {_start = Position {_line = 7, _character = 0}, _end = Position {_line = 7, _character = 28}}}] but got IdeResultOk []
finds definition in the same component - HaRePlugin.hare plugin.Additional GHC API commands
Expected IdeResultOk [Location {_uri = Uri {getUri = "file:///root/build/test/testdata/gototest/src/Lib.hs"}, _range = Range {_start = Position {_line = 5, _character = 0}, _end = Position {_line = 5, _character = 8}}}] but got IdeResultOk []

I've updated the stack*.yaml files to make their formatting more similar to master, to make diffs easier.

@fendor so i think we could merge this

@jneira jneira changed the title Merge branch 'master' using haskell-lsp-0.17 Merge branch 'master' (incoming 0.13 release including haskell-lsp-0.17) Oct 23, 2019
@fendor fendor merged commit 89f8d83 into mpickering:hie-bios Oct 23, 2019
@jneira jneira deleted the hie-bios-haskell-lsp-0.17 branch October 23, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants