-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading next/previous item gets progressively slower with longer playlists #15264
Comments
Bisected to de08494 (yes, it's not a mistake). I'll need some time to figure out the "why" though More specifically, |
This partially undos the changes in de08494 for performance reasons. As mentioned in the original commit message, these don't matter much since they change multiple times on each new file anyway and the change was only done for correctness sake. Fixes: mpv-player#15264
Observing playlist property with "native" type is too expensive for larger playlists, and we only observe this property to activate/deactivate next/prev buttons on the osc. We actually only need to know if the playlist-count has changed, nothing else. Fixes: mpv-player#15264
The PR fixes the issue, you can either wait for the fix to make its way into a release or disable the built in osc with |
Can confirm, |
mpv Information
Other Information
Reproduction Steps
After updating to mpv 0.39.0 (Fedora 41), I noticed that loading the next/previous item takes progressively more time as playlists get longer. This was not the case with 0.37.0 (Fedora 40).
To replicate, simply create a long playlist and pipe into mpv like so:
With reasonable-sized images and a short playlist, loading is effectively instant. The same images take several seconds to load with 200k items in the playlist.
I'm using images to test, since I find it easier to judge loading times, but the issue is present with videos as well.
The issue is also present in the Flathub version of mpv.
Expected Behavior
Loading the next/previous playlist item is always fast, irrespective of playlist length.
Actual Behavior
Loading the next/previous playlist item seems to correlate with playlist length.
Log File
output.txt
Sample Files
No response
I carefully read all instruction and confirm that I did the following:
--log-file=output.txt
.The text was updated successfully, but these errors were encountered: