osc.lua: observe playlist-count instead of playlist property #15265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observing playlist property with "native" type is too expensive for larger playlists, and we only observe this property to activate/deactivate next/prev buttons on the osc. We actually only need to know if the playlist-count has changed, nothing else. Fixes: mpv-player#15264
llyyr
changed the title
|
Download the artifacts for this pull request: |
sfan5
reviewed
Nov 5, 2024
| @@ -2562,7 +2562,7 @@ end | |||
| mp.register_event("shutdown", shutdown) | |||
| mp.register_event("start-file", request_init) | |||
| mp.observe_property("track-list", "native", request_init) | |||
| mp.observe_property("playlist", "native", request_init) | |||
| mp.observe_property("playlist-count", "native", request_init) | |||
There was a problem hiding this comment.
this should lead by example and observe with nil if the value is not needed
(actually that seems to also apply to track-list?)
There was a problem hiding this comment.
These were changed to "native" in de08494 to avoid encouraging people to imitate the code, but I guess you're right, both can be nil.
There was a problem hiding this comment.
We changed to native in de08494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observing playlist property with "native" type is too expensive for
larger playlists, and we only observe this property to
activate/deactivate next/prev buttons on the osc. We actually only need
to know if the playlist-count has changed, nothing else.
Fixes: #15264