Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRManager: Clean up. #30349

Merged
merged 1 commit into from
Jan 17, 2025
Merged

XRManager: Clean up. #30349

merged 1 commit into from
Jan 17, 2025

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 17, 2025

Related issue: #30346

Description

Minor JSDoc related clean up.

@Mugen87 Mugen87 added this to the r173 milestone Jan 17, 2025
@Mugen87 Mugen87 merged commit 3434275 into mrdoob:dev Jan 17, 2025
5 of 6 checks passed
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.25
78.28
336.25
78.28
+0 B
+0 B
WebGPU 503.18
139.76
503.18
139.76
+0 B
+0 B
WebGPU Nodes 502.65
139.65
502.65
139.65
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.25
112.13
465.25
112.13
+0 B
+0 B
WebGPU 576.96
156.41
576.96
156.41
+0 B
+0 B
WebGPU Nodes 532.35
145.96
532.35
145.96
+0 B
+0 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant