Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRManager: Clean up. #30349

Merged
merged 1 commit into from
Jan 17, 2025
Merged

XRManager: Clean up. #30349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/renderers/common/XRManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ const _cameraRPos = /*@__PURE__*/ new Vector3();
* manage XR sessions with `WebGPURenderer`.
*
* XR is currently only supported with a WebGL 2 backend.
*
* @augments EventDispatcher
*/
class XRManager extends EventDispatcher {

Expand Down Expand Up @@ -380,9 +382,9 @@ class XRManager extends EventDispatcher {
}

/**
* Returns the frammebuffer scale factor.
* Returns the framebuffer scale factor.
*
* @return {Number} The frammebuffer scale factor.
* @return {Number} The framebuffer scale factor.
*/
getFramebufferScaleFactor() {

Expand All @@ -391,11 +393,11 @@ class XRManager extends EventDispatcher {
}

/**
* Sets the frammebuffer scale factor.
* Sets the framebuffer scale factor.
*
* This method can not be used during a XR session.
*
* @param {Number} factor - The frammebuffer scale factor.
* @param {Number} factor - The framebuffer scale factor.
*/
setFramebufferScaleFactor( factor ) {

Expand Down Expand Up @@ -598,7 +600,7 @@ class XRManager extends EventDispatcher {

/**
* This method is called by the renderer per frame and updates the XR camera
* and it sub cameras based on the given camera. The given camera is the "normal"
* and it sub cameras based on the given camera. The given camera is the "user"
* camera created on application level and used for non-XR rendering.
*
* @param {PerspectiveCamera} camera - The camera.
Expand Down
Loading