Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0-rc.1 #233

Merged
merged 40 commits into from
Mar 2, 2018
Merged

Release 1.0.0-rc.1 #233

merged 40 commits into from
Mar 2, 2018

Conversation

dmtrKovalenko
Copy link
Member

No description provided.

dmtrKovalenko and others added 30 commits February 13, 2018 15:43
Rerun validation when maxDate or minDate props is changed
remove hardcoded width for DateTimePicker's Toolbar date header
Fix missed mask with null value
"prop-types": "^15.6.0",
"react": "^16.2.0",
"react-dom": "^16.2.0"
},
"externalDependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't find any info about this externalDependencies key. Shouldn't moment and date-fns be in peerDependencies? I'm not sure if it's possible to mention one of there though...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not possible, and good that you mention - I forgot to add error inside the utils file, that some of required library not installed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about printing info about utils after package is installed? Like 'jss' does it for opencollective support ?

"fs-extra": "^4.0.2",
"glob": "^7.1.2",
"jest": "^21.2.1",
"material-ui": "^1.0.0-beta.33",
"material-ui": "^1.0.0-beta.35",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all breaking changes of mui 34 already resolved? If so, mui needs to be updated in peerDependencies too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, there are no breaking changes in mui 35, so this release will support mui 34 as well

Copy link
Member Author

@dmtrKovalenko dmtrKovalenko Mar 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have not Switches, checkbox and radios so there were no breaking changes for us :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated dependency, not the peer dependency here.

@dmtrKovalenko
Copy link
Member Author

@cherniavskii I have added a prompt, and I think we are ready to release new pickers :)
If you have not any additional questions, lets go ahead!

@cherniavskii
Copy link
Member

But wait, CI failed :/

@dmtrKovalenko
Copy link
Member Author

I have accidentally remove date-fns from lib dev dependencies, which required for tests :)

@dmtrKovalenko dmtrKovalenko merged commit dd46ce2 into master Mar 2, 2018
@cherniavskii cherniavskii deleted the develop branch March 2, 2018 13:45
@cherniavskii cherniavskii restored the develop branch March 3, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants