-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.0-rc.1 #233
Release 1.0.0-rc.1 #233
Conversation
New build system
Rerun validation when maxDate or minDate props is changed
remove hardcoded width for DateTimePicker's Toolbar date header
Fix missed mask with null value
[WIP] Replace moment
223 adornment customization
Fix custom elements example
"prop-types": "^15.6.0", | ||
"react": "^16.2.0", | ||
"react-dom": "^16.2.0" | ||
}, | ||
"externalDependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't find any info about this externalDependencies
key. Shouldn't moment
and date-fns
be in peerDependencies
? I'm not sure if it's possible to mention one of
there though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not possible, and good that you mention - I forgot to add error inside the utils file, that some of required library not installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about printing info about utils after package is installed? Like 'jss' does it for opencollective support ?
"fs-extra": "^4.0.2", | ||
"glob": "^7.1.2", | ||
"jest": "^21.2.1", | ||
"material-ui": "^1.0.0-beta.33", | ||
"material-ui": "^1.0.0-beta.35", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all breaking changes of mui 34 already resolved? If so, mui needs to be updated in peerDependencies
too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, there are no breaking changes in mui 35, so this release will support mui 34 as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have not Switches, checkbox and radios so there were no breaking changes for us :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated dependency, not the peer dependency here.
…ld output for es2015 task
@cherniavskii I have added a prompt, and I think we are ready to release new pickers :) |
But wait, CI failed :/ |
I have accidentally remove date-fns from lib dev dependencies, which required for tests :) |
No description provided.