-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difference between Lab and Core components? #19448
Comments
@jcafiero The main difference between the lab and the core is how we version the components. In the current state of the lab, we are not aware of any significant breaking change we will need to apply. However, we will use them to incentivize users to upgrade to v5 (Q3-Q4 2020), to counterbalance the breaking changes we have planned. We might want to improve this page https://material-ui.com/components/about-the-lab/ to clear it up. |
Is there a clear path to core though? As in, can we as developers know if a certain component is "almost ready" for moving to the core? - Will it be next version, or the one after that or..... |
When do we move a lab component into the core?I think that we need the component:
A few notes on the current components in the lab.
|
@oliviertassinari Thank you for clarifying this for me. I agree, I think it would be beneficial to add a small description of the difference between a lab and core component to the page you highlighted above. Where can we find a list of the features missing from a component, like what you mentioned about Tree View? |
@jcafiero If it's something you want to contribute, we would be happy to review it.
You could look at the issues that have the TreeView label. |
Yeah I can submit a PR sometime next week. Thanks! |
I would add:
We recently agreed that a component doesn't need to be typed to be added to the lab, but it would do to move to the core.
I may be mistaken, but I don't think all the lab components currently have comprehensive tests.
I agree, we shouldn't merge them. 😉 More seriously, I'll give basically the same answer I've given every other time this has been suggested: The have distinctly different concerns, both functionally and stylistically, so no, they shouldn't be merged. |
@oliviertassinari I'm curious what's meant by using Google Analytics to evaluate component usage. It's ambiguous if this refers tof how often a component's documentation page is being read or if analytics code is being injected into production apps using lab components. The latter would be worrying, especially since the lab documentation doesn't expand on this point further, but it also seems unlikely. Could you clarify? |
@bthall16 It's a reference to the documentation pages. I will clarify it, thanks for raising it. |
I was wondering if anybody could tell me what the differences are between the Lab and Core components. What is required of a component before it can move from the lab to the core package?
The text was updated successfully, but these errors were encountered: