-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Have more details about FormControl, FormGroup etc. #8159
Labels
docs
Improvements or additions to the documentation
good first issue
Great for first contributions. Enable to learn the contribution process.
Comments
oliviertassinari
added
docs
Improvements or additions to the documentation
v1
good first issue
Great for first contributions. Enable to learn the contribution process.
labels
Sep 12, 2017
oliviertassinari
added a commit
that referenced
this issue
Sep 16, 2017
- [docs] Fix broken url link - [Popover] Remove unsupported modal property from the Popover component that doesn't match his role. Closes #8202 - [Tooltip] Add accessibility support - [Tooltip] Rename label to title property to match HTML feature wording - [Tooltip] Add a warning when using the title native feature at the same time - [Form] Extend the description of the component. It's not perfect, still is better. Closes #8159 - [Menu] Second iteration on focus issue Closes #8169
I have added more information to the API pages. It's better but not perfect. |
I believe the example mentioned above would be useful to have on the FormControl documentation page. |
@Gems Do you want to add such an example for the composition of the form input elements? |
@oliviertassinari at the moment I don’t feel confident in my full
understanding of the design and what the example should be. I’ll take a
deeper dive into the subject and may be could do something about it.
…On Thu, 16 May 2019 at 15:31, Olivier Tassinari ***@***.***> wrote:
@Gems <https://github.com/Gems> Do you want to add such an example for
the composition of the form input elements?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8159>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACHTCY7JADF7NPDDYMYKRTPVVO2HANCNFSM4D2RHSMA>
.
|
This was referenced May 31, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Improvements or additions to the documentation
good first issue
Great for first contributions. Enable to learn the contribution process.
So i've been trying to understand what are the different From* components are used for and what are the differences between them and what i should use with what.
I was forced to go to the source to actually understand what they do.
Should we have a more detailed information about those components? The documentation on the API doc is pretty minimal
Currently they are used in several examples yet i didnt fully understand their purpose.
For example, in the
checkbox
example all the checkboxes are placed in aFormGroup
. They can be placed in aFormControl
as well with aFormLabel
(am i correct?), yet if i put adisabled
prop onFormControl
, the checkboxes are not disabled. Not sure if that's intended or notThe text was updated successfully, but these errors were encountered: