Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Batch of fixes #15996

Merged
merged 10 commits into from
Jun 1, 2019
Merged

Conversation

oliviertassinari
Copy link
Member

I have batched a couple of small fixes for problems I have identified since the beginning of the week:

  • docs (e8188f3): Fix Invalid prop type warning. We are mixing "true" with true, only the latter should be used.
  • docs (cfdc1e7): Card fix image resolution: 400px width display vs 345px width image
  • docs (1e7c4e1): Fix Blokt image
    Capture d’écran 2019-05-31 à 18 40 05
  • CircularProgress (0399f16): Handle default props regression. This one is linked to the removal of .defaultProps.
  • docs (903d8db): Force code left-to-right. As we agreed on, the code should always be left-to-right. I'm using the CSS direction property instead of the DOM dir attribute to format everything, even the embedded markdown code:
    Capture d’écran 2019-05-31 à 18 42 43
  • Tooltip (03ab423): Fix RTL positioning. I'm using the flip: false option of jss-rtl:
    Capture d’écran 2019-05-31 à 18 43 43
  • docs (ac34a40): Fix Confirmation dialogs state. This problem was reported by Sebastian.
    Capture d’écran 2019-05-31 à 18 44 19
  • docs (95f65c1): Provide a composition demo in the FormControl API. Following [docs] Have more details about FormControl, FormGroup etc. #8159 (comment).
  • docs (86cffbd): Fix Nu Html Checker errors
    Capture d’écran 2019-05-31 à 18 45 31

Closes #15994

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation PR: good for merge labels Jun 1, 2019
@mbrookes mbrookes mentioned this pull request Jun 1, 2019
2 tasks
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 1, 2019

Details of bundle changes.

Comparing: d533b46...999994f

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% +0.01% 🔺 317,442 317,450 86,957 86,962
@material-ui/core/Paper 0.00% 0.00% 67,922 67,922 20,181 20,181
@material-ui/core/Paper.esm 0.00% 0.00% 61,217 61,217 18,977 18,977
@material-ui/core/Popper 0.00% 0.00% 28,728 28,728 10,345 10,345
@material-ui/core/Textarea 0.00% 0.00% 5,513 5,513 2,378 2,378
@material-ui/core/TrapFocus 0.00% 0.00% 3,755 3,755 1,575 1,575
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,978 15,978 5,786 5,786
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 974 974
@material-ui/lab +0.01% 🔺 +0.01% 🔺 138,855 138,863 42,673 42,676
@material-ui/styles 0.00% 0.00% 51,386 51,386 15,193 15,193
@material-ui/system 0.00% 0.00% 14,463 14,463 4,178 4,178
Button 0.00% 0.00% 83,901 83,901 25,467 25,467
Modal 0.00% 0.00% 20,342 20,342 6,688 6,688
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing +0.01% 🔺 +0.02% 🔺 55,364 55,371 13,911 13,914
docs.main -0.00% 0.00% 649,683 649,679 205,139 205,139
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 291,336 291,344 83,266 83,270

Generated by 🚫 dangerJS against 999994f

@oliviertassinari oliviertassinari merged commit e2b5542 into mui:master Jun 1, 2019
@oliviertassinari oliviertassinari deleted the batch-fixes-v3 branch June 1, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip position is broken in RTL
2 participants