-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Include default values in IntelliSense #22447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started from ButtonBase
@material-ui/lab: parsed: +0.12% , gzip: +0.17% |
oliviertassinari
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not so sure about this one. I think
@default
is fundamentally flawed when spreading props.ButtonBase
havingtype="button"
is not the same asButton
documenting this as a default value. This is only noticeable for custom variants at the moment though.The default values (for documented props in e.g. https://material-ui.com/api/chip/#props) are now part of IntelliSense.
We verify that actual default values are kept in sync with default values from the
@default
annotation inyarn docs:api
. This fails if:there is a documented default value but no
@default
annotationthere is a documented default value but the
@default
annotation does not matchthere is a
@default
annotation but no default value at runtimeThis ensures that IntelliSense displays the same as the docs. One could argue that we have more space in IntelliSense and could therefore document more default values. We can follow-up on this with concrete use cases.