Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Batch small changes #22565

Merged
merged 11 commits into from
Sep 13, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 11, 2020

  • [docs] Fix the wrong alt for diamond sponsor 7ddf7de: spotted in X but also duplicate reported by Wave Chrome extension.

Capture d’écran 2020-09-11 à 22 55 53

@oliviertassinari oliviertassinari added umbrella For grouping multiple issues to provide a holistic view core Infrastructure work going on behind the scenes labels Sep 11, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 11, 2020

Details of bundle changes

Generated by 🚫 dangerJS against de8efbc

@mbrookes
Copy link
Member

[docs] Remove blank lines

Any particular reason? They help with readability, and removing them doesn't save any meaningful bytes.

@eps1lon
Copy link
Member

eps1lon commented Sep 12, 2020

[docs] Remove blank lines

Any particular reason? They help with readability, and removing them doesn't save any meaningful bytes.

If I remember the discussion correctly then it was about consistency. I don't have a strong opinion either way. However, if the goal is consistency then adding blank lines between tags could potentially hurt readability as the number of tags grows.

Though from experience I'd advise against arguing about formatting that requires human interaction. I don't remember the pre-prettier days very fondly 😉

@@ -150,7 +150,7 @@ declare module '@material-ui/core/styles/createBreakpoints' {

#### Arguments

1. `key` (_String_ | _Number_): A breakpoint key (`xs`, `sm`, etc.) or a screen width number in pixels.
1. `key` (_String_ | _Number_): A breakpoint key (`xs`, `sm`, etc.) or a screen width number in px.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. `key` (_String_ | _Number_): A breakpoint key (`xs`, `sm`, etc.) or a screen width number in px.
1. `key` (_String_ | _Number_): A breakpoint key (`xs`, `sm`, etc.) or a screen width number in px.

Should we make these px?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are already px?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or did you mean px vs px?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, px rather than px?

Copy link
Member Author

@oliviertassinari oliviertassinari Sep 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fair, why not

@oliviertassinari
Copy link
Member Author

Regarding @tags, we can find a discussion about it on: #22447 (comment). I'm using the new convention we went with.

@oliviertassinari oliviertassinari merged commit 8ecd50a into mui:next Sep 13, 2020
@oliviertassinari oliviertassinari deleted the batch-small-changes-v30 branch September 13, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants