-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Redesign on markdown page #27860
Conversation
I noticed one problem when I played with the scrollbar, namely the global styles ar propagated to the demos too (see the scrollbar on the demo) Not sure what we should do with this one. cc @siriwatknp @oliviertassinari I feel like in the end we may need to isolate all examples in iframes :\ |
Nice work! I've pushed some small changes here and there. Listing some other ones I couldn't do:
|
@mnajdova There is an open GitHub issue that describes the next step for the scrollbar on dark mode. The plan is to remove the global overrides because it comes with too many downsides vs. the alternative. |
I've found it, linking it here for future reference #25016 I will revert for the now the changes for the scrollbar, we can come back to this after the v5 stable release. |
Agree, let's keep the scope smaller, so that we can iterate faster :) |
Fixed with b2dcfa0
Fixed with 367273c
We talked offline, we need to find better color over here - https://github.com/mui-org/material-ui/blob/next/docs/src/modules/components/Demo.js#L110
You should be able to change it over here - https://github.com/mui-org/material-ui/blob/next/docs/src/modules/components/AppLayoutDocs.js#L36 Not sure what is the best value to be honest. |
@danilo-leal leaving a note that we need to find better color for this use-case as well: |
@@ -110,7 +110,7 @@ export const getDesignTokens = (mode: 'light' | 'dark') => | |||
({ | |||
palette: { | |||
primary: blue, | |||
divider: mode === 'dark' ? blueDark[400] : grey[200], | |||
divider: mode === 'dark' ? blueDark[700] : grey[200], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flexShrink: 0, | ||
position: 'sticky', | ||
height: 'calc(100vh - 70px)', | ||
overflowY: 'auto', | ||
padding: theme.spacing(2, 2, 2, 0), | ||
padding: theme.spacing(2, 5, 2, 0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about this? that will reduce the space of text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments, the rest looks good.
I will let @danilo-leal respond. The changes are mostly his :) |
I am going to merge this one to leverage some fixes we already have as part of the PR. Will leave the unaddressed comments by @siriwatknp open, so that we can decide and address them in the next PR. |
Hmm... the font for Also not convinced about the |
Preview: https://deploy-preview-27860--material-ui.netlify.app/components/alert/
Changes done:
Table content:
Prev:
Now:
Demo toolbar
Prev:
Now:
Page heading
Prev:
Now:
TODO:
API link
Prev:
Now:
Updated the colors on the content of the docs pages
Next iteration:
Scrollbar dark mode - will be handled after #25016 is fixed