Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codemod] Leave numeric arguments to breakpoints functions unchanged #32426

Merged
merged 1 commit into from
Apr 28, 2022
Merged

[codemod] Leave numeric arguments to breakpoints functions unchanged #32426

merged 1 commit into from
Apr 28, 2022

Conversation

ryancogswell
Copy link
Contributor

The codemod was previously changing numeric values to undefined

@ryancogswell
[codemod] Leave numeric arguments to breakpoints functions unchanged
32b72af 
- The codemod was previously changing numeric values to `undefined`
@mui-bot
Copy link

mui-bot commented Apr 23, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 32b72af

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work v5.x migration package: codemod Specific to @mui/codemod labels Apr 23, 2022
oliviertassinari
oliviertassinari reviewed Apr 23, 2022
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

mnajdova
mnajdova approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mnajdova mnajdova merged commit 5d31b54 into mui:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work package: codemod Specific to @mui/codemod v5.x migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryancogswell @mui-bot @oliviertassinari @mnajdova