[docs] Enforce no trailing spaces #34762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,7 +11,7 @@ module.exports = { | |||
| // closing double quote: \xE2\x80\x9D | |||
| if (line.match('[‘’“”]')) { | |||
| onError({ | |||
| lineNumber, | |||
| lineNumber: lineNumber + 1, | |||
There was a problem hiding this comment.
This was wrong, see how the lint failed with the wrong error message:
docs/pages/blog/mui-x-v6-alpha-zero.md:9 straightQuotes Only allow straight quotes. [This rule threw an exception: Property 'lineNumber' of onError parameter is incorrect.]
Comment on lines
-886
to
-890
|
|
||
| :::warning | ||
| For [Storybook](https://storybook.js.org): At the time of this writing, Storybook still uses Emotion 10 by default. | ||
| Material UI and TSS use Emotion 11, so you must make [some changes](https://github.com/InseeFrLab/onyxia-ui/blob/324de62248074582b227e584c53fb2e123f5325f/.storybook/main.js#L31-L32) to `.storybook/main.js` in order to use Storybook with Material UI. | ||
| ::: |
There was a problem hiding this comment.
I don't think that mentioning Storybook makes sense in the context of style library interoperability, plus the content is outdated now: https://twitter.com/storybookjs/status/1578033180883693568.
|
| '**/node_modules/**', | ||
| '**/*-zh.md', | ||
| '**/*-pt.md', | ||
| '**/build/**', |
There was a problem hiding this comment.
I have missed this, for those that do releases locally, they had a couple of changelogs in the build that fail the lining rule.
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
enforce-no-trailing-spaces
branch
from
6c127e4 to
273c99d
Compare
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
enforce-no-trailing-spaces
branch
from
273c99d to
b9cce50
Compare
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
force-pushed
the
enforce-no-trailing-spaces
branch
from
b9cce50 to
1bf301a
Compare
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a continuation of this discussion #34686. The value is about being able to more accurately understand how the markdown will render. A double space for adding a line break is almost invisible during the PR reviews but
\is visible.