-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Enforce no trailing spaces #34762
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1701,7 +1701,8 @@ All contributors of this release in alphabetical order: @abhinav-22-tech, @ainat | |
|
||
_Apr 18, 2022_ | ||
|
||
A big thanks to the 11 contributors who made this release possible. This release is mostly about 🐛 bug fixes and 📚 documentation improvements. | ||
A big thanks to the 11 contributors who made this release possible. | ||
This release is mostly about 🐛 bug fixes and 📚 documentation improvements. | ||
|
||
### `@mui/[email protected]` | ||
|
||
|
@@ -1760,7 +1761,7 @@ All contributors of this release in alphabetical order: @abaker93, @cherniavskii | |
|
||
_Apr 11, 2022_ | ||
|
||
A big thanks to the 8 contributors who made this release possible. | ||
A big thanks to the 8 contributors who made this release possible. | ||
This release is mostly about 🐛 bug fixes and 📚 documentation improvements. | ||
|
||
### `@mui/[email protected]` | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -883,8 +883,3 @@ There is [an ESLint plugin](https://docs.tss-react.dev/detecting-unused-classes) | |
⚠️ **Keep `@emotion/styled` as a dependency of your project**. Even if you never use it explicitly, | ||
it's a peer dependency of `@mui/material`. | ||
::: | ||
|
||
:::warning | ||
For [Storybook](https://storybook.js.org): At the time of this writing, Storybook still uses Emotion 10 by default. | ||
Material UI and TSS use Emotion 11, so you must make [some changes](https://github.com/InseeFrLab/onyxia-ui/blob/324de62248074582b227e584c53fb2e123f5325f/.storybook/main.js#L31-L32) to `.storybook/main.js` in order to use Storybook with Material UI. | ||
::: | ||
Comment on lines
-886
to
-890
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think that mentioning Storybook makes sense in the context of style library interoperability, plus the content is outdated now: https://twitter.com/storybookjs/status/1578033180883693568. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ module.exports = { | |
// closing double quote: \xE2\x80\x9D | ||
if (line.match('[‘’“”]')) { | ||
onError({ | ||
lineNumber, | ||
lineNumber: lineNumber + 1, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was wrong, see how the lint failed with the wrong error message:
|
||
details: `For line: ${line}`, | ||
}); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have missed this, for those that do releases locally, they had a couple of changelogs in the build that fail the lining rule.