Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.23.4 #16003

Merged
merged 4 commits into from
Dec 27, 2024
Merged

v7.23.4 #16003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7a6037
v7.23.4
DanailH Dec 26, 2024
d44ec16
Update CHANGELOG.md
DanailH Dec 26, 2024
2e0b67b
Update CHANGELOG.md
DanailH Dec 26, 2024
8ccaf79
Update CHANGELOG.md
DanailH Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,44 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## v7.23.4

_Dec 27, 2024_

We'd like to offer a big thanks to the 4 contributors who made this release possible. Here are some highlights ✨:

Check warning on line 10 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Google.We] Try to avoid using first-person plural like 'We'.

Raw Output:
{"message": "[Google.We] Try to avoid using first-person plural like 'We'.", "location": {"path": "CHANGELOG.md", "range": {"start": {"line": 10, "column": 1}}}, "severity": "WARNING"}

- 🌍 Improve Dutch (nl-NL) locale on the Data Grid
- 🐞 Bugfixes

Special thanks go out to the community contributor who has helped make this release possible:
@JoepVerkoelen.
Following are all team members who have contributed to this release:
@arminmeh, @oliviertassinari.

<!--/ HIGHLIGHT_ABOVE_SEPARATOR /-->

### Data Grid

#### `@mui/[email protected]`

- [DataGrid] Fix header filters showing clear button while empty (#15990) @k-rajat19
- [DataGrid] Replace `forwardRef` with a shim for forward compatibility (#15984) @lauri865
- [l10n] Improve Dutch (nl-NL) locale (#15920) @JoepVerkoelen

#### `@mui/[email protected]` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link 'Pro plan')

Same changes as in `@mui/[email protected]`.

#### `@mui/[email protected]` [![premium](https://mui.com/r/x-premium-svg)](https://mui.com/r/x-premium-svg-link 'Premium plan')

Same changes as in `@mui/[email protected]`, plus:

- [DataGridPremium] Fix column pinning with checkbox selection and row grouping (#15949) @k-rajat19

### Docs

- [docs] Fix outdated link to handbook (#15855) @oliviertassinari

## 7.23.3

_Dec 19, 2024_
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "7.23.3",
"version": "7.23.4",
"private": true,
"scripts": {
"preinstall": "npx only-allow pnpm",
Expand Down Expand Up @@ -201,9 +201,9 @@
"react-is": "^18.3.1",
"@types/node": "^20.16.11"
},
"packageManager": "pnpm@9.12.1",
"packageManager": "pnpm@9.15.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what caused this change?

Copy link
Member Author

@DanailH DanailH Dec 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did 😄 It's 9.15.1 on master and I figured they should match, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not sure 🤔
Maybe someone from @mui/code-infra can advise?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no arguments against this. 🤷
It goes out of sync because we stop bumping dependencies on anything other than master. 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasTy I did it mostly for convenience - It's annoying to switch the version of pnpm when releasing from master and v7.x
On another note - have you thought about stopping the releases for v7?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it mostly for convenience - It's annoying to switch the version of pnpm when releasing from master and v7.x

Are you using corepack?
The version should be picked up automatically if you have it installed.
But I agree that it could still end up annoying if the person doing the release does not have that particular outdated version released. 🙈

On another note - have you thought about stopping the releases for v7?

I don't think we've had this discussion yet. 🤔
AFAIK, we keep releasing the current stable if there are any relevant bug fixes and/or localization changes while we are in the pre-release phase.
Once the current major changes—releasing prior versions becomes increasingly less frequent. It's mostly bigger bug fixes that we consider back-porting.

"engines": {
"pnpm": "9.12.1"
"pnpm": "9.15.1"
},
"pnpm": {
"patchedDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid-generator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-data-grid-generator",
"version": "7.23.3",
"version": "7.23.4",
"description": "Generate fake data for demo purposes only.",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid-premium/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-data-grid-premium",
"version": "7.23.3",
"version": "7.23.4",
"description": "The Premium plan edition of the Data Grid Components (MUI X).",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid-pro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-data-grid-pro",
"version": "7.23.3",
"version": "7.23.4",
"description": "The Pro plan edition of the Data Grid components (MUI X).",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid/package.json
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, something went wrong with this release. The @mui/x-internals package wasn't bumped for some reason, which results in the following error: https://stackblitz.com/edit/react-fur42je2?file=Demo.tsx

Error in turbo_modules/@mui/[email protected]/node/components/GridColumnHeaders.js
The entrypoint for '@mui/x-internals' could not successfully be resolved. The file '/turbo_modules/@mui/[email protected]/forwardRef' does not exist. Please log an issue with the package author or check for an updated version of the package.

And indeed, there's no forwardRef export in @mui/[email protected] that the latest version is trying to use: https://unpkg.com/@mui/[email protected]/package.json

@DanailH We need to release a bugfix that would include releasing @mui/x-internals

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we are on top of it. @MBilalShafi is prepping a patch because only releasing x-internals won't fix the issue.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-data-grid",
"version": "7.23.3",
"version": "7.23.4",
"description": "The Community plan edition of the Data Grid components (MUI X).",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
Loading