v7.23.4 #16003
v7.23.4 #16003
Conversation
|
Deploy preview: https://deploy-preview-16003--material-ui-x.netlify.app/ |
| @@ -201,9 +201,9 @@ | |||
| "react-is": "^18.3.1", | |||
| "@types/node": "^20.16.11" | |||
| }, | |||
| "packageManager": "pnpm@9.12.1", | |||
| "packageManager": "pnpm@9.15.1", | |||
There was a problem hiding this comment.
Do you know what caused this change?
There was a problem hiding this comment.
I did 😄 It's 9.15.1 on master and I figured they should match, right?
There was a problem hiding this comment.
Hmm, I'm not sure 🤔
Maybe someone from @mui/code-infra can advise?
There was a problem hiding this comment.
I have no arguments against this. 🤷
It goes out of sync because we stop bumping dependencies on anything other than master. 🤷
There was a problem hiding this comment.
@LukasTy I did it mostly for convenience - It's annoying to switch the version of pnpm when releasing from master and v7.x
On another note - have you thought about stopping the releases for v7?
There was a problem hiding this comment.
I did it mostly for convenience - It's annoying to switch the version of pnpm when releasing from master and v7.x
Are you using corepack?
The version should be picked up automatically if you have it installed.
But I agree that it could still end up annoying if the person doing the release does not have that particular outdated version released. 🙈
On another note - have you thought about stopping the releases for v7?
I don't think we've had this discussion yet. 🤔
AFAIK, we keep releasing the current stable if there are any relevant bug fixes and/or localization changes while we are in the pre-release phase.
Once the current major changes—releasing prior versions becomes increasingly less frequent. It's mostly bigger bug fixes that we consider back-porting.
Co-authored-by: Michel Engelen <[email protected]> Signed-off-by: Danail Hadjiatanasov <[email protected]>
Co-authored-by: Andrew Cherniavskii <[email protected]> Signed-off-by: Danail Hadjiatanasov <[email protected]>
| @@ -201,9 +201,9 @@ | |||
| "react-is": "^18.3.1", | |||
| "@types/node": "^20.16.11" | |||
| }, | |||
| "packageManager": "pnpm@9.12.1", | |||
| "packageManager": "pnpm@9.15.1", | |||
There was a problem hiding this comment.
I have no arguments against this. 🤷
It goes out of sync because we stop bumping dependencies on anything other than master. 🤷
Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Danail Hadjiatanasov <[email protected]>
There was a problem hiding this comment.
Hmm, something went wrong with this release. The @mui/x-internals package wasn't bumped for some reason, which results in the following error: https://stackblitz.com/edit/react-fur42je2?file=Demo.tsx
Error in turbo_modules/@mui/[email protected]/node/components/GridColumnHeaders.js
The entrypoint for '@mui/x-internals' could not successfully be resolved. The file '/turbo_modules/@mui/[email protected]/forwardRef' does not exist. Please log an issue with the package author or check for an updated version of the package.
And indeed, there's no forwardRef export in @mui/[email protected] that the latest version is trying to use: https://unpkg.com/@mui/[email protected]/package.json
@DanailH We need to release a bugfix that would include releasing @mui/x-internals
There was a problem hiding this comment.
Yes, we are on top of it. @MBilalShafi is prepping a patch because only releasing x-internals won't fix the issue.
No description provided.