v7.23.5 #16010
v7.23.5 #16010
Conversation
Signed-off-by: Bilal Shafi <[email protected]>
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@mui/x-license", | |||
| "version": "7.23.2", | |||
| "version": "7.23.5", | |||
There was a problem hiding this comment.
Did Lerna suggest bumping this package? 🤔
It doesn't look like it had any changes between 7.32.2 and now. 🤷
There was a problem hiding this comment.
I also skipped it for the one I did.
There was a problem hiding this comment.
Lerna suggested nothing 😄
I had to use --force-publish to make it bump the packages.
I thought we usually bump x-grid-generator and x-license anyways, isn't it?
Or is it only with x-grid-generator 🤔
I'll revert x-license bump in that case.
There was a problem hiding this comment.
I'm ok with bumping it but why not go to 7.23.3?
There was a problem hiding this comment.
Gotcha.
Did --force-publish suggest other product packages? 🤔
I'm ok with bumping it but why not go to 7.23.3?
Because we sync the package versions whenever we do a release. 😉
There was a problem hiding this comment.
Because we sync the package versions whenever we do a release. 😉
Do we? I also thought the same but later assumed it's not the case anymore and adjusted the versions to incrementing only one. 🤦
There was a problem hiding this comment.
Did --force-publish suggest other product packages? 🤔
Yes, every package. I skipped the others manually.
There was a problem hiding this comment.
Because we sync the package versions whenever we do a release. 😉
Let's have a consensus on it and make it part of scripts/README.md
@mui/x Are we OK on syncing the package versions whenever we release?
👍 = YES 👎 = NO. Release should be done incrementing by 1
There was a problem hiding this comment.
OK, so we only miss the version update for @mui/x-internals and @mui/x-license and we should be good to go 👍🏻
|
Deploy preview: https://deploy-preview-16010--material-ui-x.netlify.app/ |
Co-authored-by: Bilal Shafi <[email protected]> Signed-off-by: Danail Hadjiatanasov <[email protected]>
This reverts commit aee81d7.
Fix #16007
Skipping publishing of
@mui/x-internalscaused these changes mess up the codesandbox/stackblitz demos.