Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.23.5 #16010

Merged
merged 5 commits into from
Dec 27, 2024
Merged

v7.23.5 #16010

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb7641c
7.23.5
MBilalShafi Dec 27, 2024
edb16f3
Update CHANGELOG.md
MBilalShafi Dec 27, 2024
aee81d7
adjust versions
MBilalShafi Dec 27, 2024
f3eb7b6
Update CHANGELOG.md
DanailH Dec 27, 2024
8c052ad
Revert "adjust versions"
MBilalShafi Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,30 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## 7.23.5

_Dec 27, 2024_

We'd like to offer a big thanks to the 0 contributors who made this release possible. Here are some highlights ✨:

Check warning on line 10 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Google.We] Try to avoid using first-person plural like 'We'.

Raw Output:
{"message": "[Google.We] Try to avoid using first-person plural like 'We'.", "location": {"path": "CHANGELOG.md", "range": {"start": {"line": 10, "column": 1}}}, "severity": "WARNING"}
MBilalShafi marked this conversation as resolved.
Show resolved Hide resolved

- 🐞 Fix version mismatch issue in codesandbox/stackblitz demos
DanailH marked this conversation as resolved.
Show resolved Hide resolved

<!--/ HIGHLIGHT_ABOVE_SEPARATOR /-->

### Data Grid

#### `@mui/[email protected]`

No changes since `@mui/[email protected]`.

#### `@mui/[email protected]` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link 'Pro plan')

Same changes as in `@mui/[email protected]`.

#### `@mui/[email protected]` [![premium](https://mui.com/r/x-premium-svg)](https://mui.com/r/x-premium-svg-link 'Premium plan')

Same changes as in `@mui/[email protected]`.

## v7.23.4

_Dec 27, 2024_
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "7.23.4",
"version": "7.23.5",
"private": true,
"scripts": {
"preinstall": "npx only-allow pnpm",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid-generator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-data-grid-generator",
"version": "7.23.4",
"version": "7.23.5",
"description": "Generate fake data for demo purposes only.",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid-premium/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-data-grid-premium",
"version": "7.23.4",
"version": "7.23.5",
"description": "The Premium plan edition of the Data Grid Components (MUI X).",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid-pro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-data-grid-pro",
"version": "7.23.4",
"version": "7.23.5",
"description": "The Pro plan edition of the Data Grid components (MUI X).",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-data-grid",
"version": "7.23.4",
"version": "7.23.5",
"description": "The Community plan edition of the Data Grid components (MUI X).",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-internals/package.json
View file
Open in desktop
cherniavskii marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-internals",
"version": "7.23.0",
"version": "7.23.5",
"description": "Utility functions for the MUI X packages (internal use only).",
"author": "MUI Team",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-license/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-license",
"version": "7.23.2",
"version": "7.23.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did Lerna suggest bumping this package? 🤔
It doesn't look like it had any changes between 7.32.2 and now. 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also skipped it for the one I did.

Copy link
Member Author

@MBilalShafi MBilalShafi Dec 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lerna suggested nothing 😄
I had to use --force-publish to make it bump the packages.

I thought we usually bump x-grid-generator and x-license anyways, isn't it?
Or is it only with x-grid-generator 🤔

I'll revert x-license bump in that case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with bumping it but why not go to 7.23.3?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha.
Did --force-publish suggest other product packages? 🤔

I'm ok with bumping it but why not go to 7.23.3?

Because we sync the package versions whenever we do a release. 😉

Copy link
Member Author

@MBilalShafi MBilalShafi Dec 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we sync the package versions whenever we do a release. 😉

Do we? I also thought the same but later assumed it's not the case anymore and adjusted the versions to incrementing only one. 🤦

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did --force-publish suggest other product packages? 🤔

Yes, every package. I skipped the others manually.

Copy link
Member Author

@MBilalShafi MBilalShafi Dec 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we sync the package versions whenever we do a release. 😉

Let's have a consensus on it and make it part of scripts/README.md

@mui/x Are we OK on syncing the package versions whenever we release?

👍 = YES 👎 = NO. Release should be done incrementing by 1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR opened: #16012

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so we only miss the version update for @mui/x-internals and @mui/x-license and we should be good to go 👍🏻

"description": "MUI X License verification",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
Loading