-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Improve the playground DX #6514
[core] Improve the playground DX #6514
Conversation
build | ||
CHANGELOG.md | ||
dist | ||
node_modules | ||
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort asc
@@ -8,10 +8,12 @@ | |||
"build": "cross-env NODE_ENV=production next build --profile", | |||
"build:clean": "rimraf .next && yarn build", | |||
"build-sw": "node ./scripts/buildServiceWorker.js", | |||
"dev": "rimraf ./node_modules/.cache/babel-loader && next dev --port 3001", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed since we are no longer using https://github.com/kentcdodds/babel-plugin-macros.
"start": "yarn && yarn docs:dev", | ||
"benchmark:browser": "yarn workspace benchmark browser", | ||
"docs:dev": "yarn workspace docs dev", | ||
"docs:start": "yarn workspace docs start", | ||
"docs:create-playground": "yarn workspace docs create-playground", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To match the scripts available in http://github.com/mui/material-ui.
These are the results for the performance tests:
|
3b694e1
to
198ca44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👌 👍
The documentation for this: https://github.com/mui/material-ui/blob/master/CONTRIBUTING.md#trying-changes-on-the-playground with port 3001 rather than 3000. |
commit 634aabe Author: Matheus Wichman <[email protected]> Date: Wed Oct 19 20:26:54 2022 -0300 Update migration guide commit 40bbeef Merge: d49de67 4fbb67d Author: Matheus Wichman <[email protected]> Date: Wed Oct 19 11:07:48 2022 -0300 Merge branch 'next' into rename-selection-props commit 4fbb67d Author: Danail Hadjiatanasov <[email protected]> Date: Wed Oct 19 15:26:21 2022 +0300 [test] Remove BrowserStack (mui#6263) commit fff240b Author: Olivier Tassinari <[email protected]> Date: Wed Oct 19 14:18:46 2022 +0200 [core] Fix trailing spaces and git diff format (mui#6523) Signed-off-by: Olivier Tassinari <[email protected]> commit 4488896 Author: Olivier Tassinari <[email protected]> Date: Wed Oct 19 13:37:09 2022 +0200 [core] Improve the playground DX (mui#6514) commit e195e5a Author: Olivier Tassinari <[email protected]> Date: Wed Oct 19 13:30:12 2022 +0200 [core] Link Netlify in the danger comment (mui#6513) commit a4fedc1 Author: Alexandre Fauquette <[email protected]> Date: Wed Oct 19 11:57:42 2022 +0200 [adapters] Fix localisation of the placeholder (mui#6547) commit d49de67 Author: Matheus Wichman <[email protected]> Date: Tue Oct 18 19:17:48 2022 -0300 [DataGrid] Rename selection props
A continuation of #6466 based on mui/material-ui#34739