[adapters] Fix localisation of the placeholder #6547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
alexfauquette
changed the title
alexfauquette
commented
Oct 18, 2022
Comment on lines
+65
to
+67
| return this.moment | ||
| .localeData(this.getCurrentLocaleCode()) | ||
| .longDateFormat(token as LongDateFormatKey); |
There was a problem hiding this comment.
This is needed because otherwise the default locale of moment will be applied (the last imported one)
It's a part of code copypasted from date-io. after this PR I will add the modification to date-io
alexfauquette
commented
Oct 18, 2022
| @@ -70,18 +72,25 @@ export function wrapPickerMount(mount: (node: React.ReactNode) => import('enzyme | |||
|
|
|||
| export function createPickerRenderer({ | |||
| locale, | |||
| adapterName, | |||
There was a problem hiding this comment.
We can run the entire test codebase with any of the adapters. But only some of them are relevant to be run on various adapters. That's why I add this parameter. By priority, tests run with the adapter provided by:
- adapterName
- test:unit paramter
- date-fns (default one)
flaviendelangle
approved these changes
Oct 19, 2022
m4theushw
added a commit
to m4theushw/mui-x
that referenced
this pull request
Oct 20, 2022
commit 634aabe Author: Matheus Wichman <[email protected]> Date: Wed Oct 19 20:26:54 2022 -0300 Update migration guide commit 40bbeef Merge: d49de67 4fbb67d Author: Matheus Wichman <[email protected]> Date: Wed Oct 19 11:07:48 2022 -0300 Merge branch 'next' into rename-selection-props commit 4fbb67d Author: Danail Hadjiatanasov <[email protected]> Date: Wed Oct 19 15:26:21 2022 +0300 [test] Remove BrowserStack (mui#6263) commit fff240b Author: Olivier Tassinari <[email protected]> Date: Wed Oct 19 14:18:46 2022 +0200 [core] Fix trailing spaces and git diff format (mui#6523) Signed-off-by: Olivier Tassinari <[email protected]> commit 4488896 Author: Olivier Tassinari <[email protected]> Date: Wed Oct 19 13:37:09 2022 +0200 [core] Improve the playground DX (mui#6514) commit e195e5a Author: Olivier Tassinari <[email protected]> Date: Wed Oct 19 13:30:12 2022 +0200 [core] Link Netlify in the danger comment (mui#6513) commit a4fedc1 Author: Alexandre Fauquette <[email protected]> Date: Wed Oct 19 11:57:42 2022 +0200 [adapters] Fix localisation of the placeholder (mui#6547) commit d49de67 Author: Matheus Wichman <[email protected]> Date: Tue Oct 18 19:17:48 2022 -0300 [DataGrid] Rename selection props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6540
Luxon has specific behavior about localization. You should always specify the locale when calling a method from
DateTimeNow the
adapterLocaleis applied to both the placeholder and the formatted for the 4 libraries