Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use page name on preview url #2498

Closed

Conversation

Kirera-Wainaina
Copy link
Contributor

Uses page name on url pathname, and replaces previous use of id.

For backwards compatibility, if url uses id, it is redirected to url using page e.g /pages/5q1xd0t will be redirected to /pages/basic_class

Closes #1905
pageNameInUrl

  • I've read and followed the contributing guide on how to create great pull requests.
  • I've linked relevant GitHub issue with "Closes #"
  • I've added a visual demonstration under the form of a screenshot or video

Get page name from preview url

Redirect preview url with id to preview url with name

Preview page panel uses url with page name not id
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 23, 2023
@Janpot
Copy link
Member

Janpot commented Feb 20, 2024

Thank you for looking into this, but this has now been superseded by #2949

@Janpot Janpot closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove routing pages to "id", use page name
2 participants