Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Input by duration" note input preference changes #26395

Closed
3 tasks
avvvvve opened this issue Feb 7, 2025 · 4 comments · Fixed by #26367
Closed
3 tasks

"Input by duration" note input preference changes #26395

avvvvve opened this issue Feb 7, 2025 · 4 comments · Fixed by #26367
Assignees
Labels
Input by duration Issues related to the input by duration mode P2 Priority: Medium Pre-release feature issue This pertains to a new feature and should be addressed prior to release UI Visual issues affecting the UI (not notation) UX/interaction

Comments

@avvvvve
Copy link

avvvvve commented Feb 7, 2025

This needs design signoff from @bkunda


Current default state

This is about the "Include preview notes in playback (input by duration only)" checkbox

Image

Changes

  • Make the setting ON by default (@Tantacrul's suggestion, which I'm in favor of)
  • Put the setting beneath the "Play chord symbols and Nashville numbers" checkbox
    • Reasoning: the other three settings apply to all note input modes, so the more general options should be higher up. Also, "Playback duration" should not fall between other checkboxes because it applies to the whole group.
  • (Still needs design signoff) Update the copy to make it less vague and align it to other settings. Options:
    • 'Play when setting pitch (input by duration mode only)'
    • 'Play when setting pitch with arrow keys (input by duration mode only)'
      • 👍 Ben's pick

That would get us (for 4.5) to this:

Image

...and later, when other in-progress MIDI preferences are ready, it would all come together like this:

Image
@avvvvve avvvvve added needs design Design is needed Pre-release feature issue This pertains to a new feature and should be addressed prior to release UI Visual issues affecting the UI (not notation) UX/interaction labels Feb 7, 2025
@avvvvve avvvvve moved this to To do in MuseScore Studio 4.5 Feb 7, 2025
@bkunda
Copy link

bkunda commented Feb 10, 2025

I think this is a cleaner option. Happy to approve.

@bkunda bkunda assigned RomanPudashkin and unassigned bkunda Feb 10, 2025
@bkunda bkunda added P2 Priority: Medium and removed needs design Design is needed labels Feb 10, 2025
@RomanPudashkin
Copy link
Contributor

@avvvvve 'Play when setting pitch with arrow keys (input by duration mode only)' -- this would be an incorrect name for the option. It produces sound not only when using the arrows, but also when you change the active pitch using the A-G shortcuts or by pressing a MIDI key

@RomanPudashkin RomanPudashkin added the Input by duration Issues related to the input by duration mode label Feb 10, 2025
RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Feb 10, 2025
@RomanPudashkin RomanPudashkin moved this from To do to In Progress in MuseScore Studio 4.5 Feb 10, 2025
@avvvvve
Copy link
Author

avvvvve commented Feb 10, 2025

Gotcha—let's just go with "Play when setting pitch (input by duration mode only)" then!

Image

RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Feb 11, 2025
@DmitryArefiev
Copy link
Contributor

@avvvvve Please check this on #26367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input by duration Issues related to the input by duration mode P2 Priority: Medium Pre-release feature issue This pertains to a new feature and should be addressed prior to release UI Visual issues affecting the UI (not notation) UX/interaction
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants