Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input by duration: various fixes #26367

Merged
merged 11 commits into from
Feb 12, 2025
Merged

Input by duration: various fixes #26367

merged 11 commits into from
Feb 12, 2025
+240 −150

Conversation

RomanPudashkin
Copy link
Contributor

@RomanPudashkin RomanPudashkin commented Feb 6, 2025 •
edited
Loading

Resolves: #26363
Resolves: #26349
Resolves: #26345
Resolves: #26325
Resolves: #26327
Resolves: #26370
Resolves: #26371
Resolves: #26373
Resolves: #26395
Resolves: #26364

This was referenced Feb 6, 2025
Closed
Open
@DmitryArefiev DmitryArefiev mentioned this pull request Feb 7, 2025
Closed
4 tasks
@DmitryArefiev
Copy link
Contributor

Tested #26349 #26345 #26325 #26327 on Win10, Mac13.6, LinuxUbuntu24.04.1 LTS - FIXED

#26363 fixed partially

mathesoncalum
mathesoncalum approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@mathesoncalum mathesoncalum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

My only question is whether m_rest in input.h is still necessary? It looks very closely linked to m_notes.empty() now (not a blocker).

@RomanPudashkin RomanPudashkin marked this pull request as draft February 10, 2025 09:02
@RomanPudashkin RomanPudashkin force-pushed the input_by_duration_fixes branch from b00dca8 to a193790 Compare February 10, 2025 10:42
@Tantacrul
Copy link
Contributor

Apart from @DmitryArefiev's comment, I've tested all of the above and they appear fixed (MacOS only).

All that's left of the issues I logged is this one, which @bkunda and I discussed and agreed should be done.
#26364

@RomanPudashkin RomanPudashkin force-pushed the input_by_duration_fixes branch from d30eaac to b8387d6 Compare February 10, 2025 14:04
@RomanPudashkin RomanPudashkin marked this pull request as ready for review February 10, 2025 14:13
@RomanPudashkin RomanPudashkin force-pushed the input_by_duration_fixes branch from b8387d6 to 93558c3 Compare February 10, 2025 14:22
@bkunda
Copy link

bkunda commented Feb 11, 2025

Looking better and better each time @RomanPudashkin!

I can also see the accidentals showing well. 😌

@RomanPudashkin RomanPudashkin force-pushed the input_by_duration_fixes branch from 93558c3 to 0335989 Compare February 11, 2025 10:17
@DmitryArefiev DmitryArefiev mentioned this pull request Feb 11, 2025
Closed
3 tasks
@DmitryArefiev
Copy link
Contributor

Tested #26363 #26349 #26345 #26325 #26327 #26370 #26371 #26373 #26364 on Win10, Mac13.6, LinuxUbuntu24.04.2 LTS - FIXED

@avvvvve Please check #26395 on your side

@avvvvve
Copy link

avvvvve commented Feb 11, 2025

@DmitryArefiev #26395 looks good! approved

@avvvvve avvvvve mentioned this pull request Feb 12, 2025
Open
4 tasks
@RomanPudashkin RomanPudashkin force-pushed the input_by_duration_fixes branch from 0335989 to f68ed47 Compare February 12, 2025 08:45
@RomanPudashkin RomanPudashkin force-pushed the input_by_duration_fixes branch from f68ed47 to ad6b33f Compare February 12, 2025 10:58
@RomanPudashkin RomanPudashkin merged commit 6558ac6 into musescore:master Feb 12, 2025
11 checks passed
@RomanPudashkin RomanPudashkin deleted the input_by_duration_fixes branch February 12, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathesoncalum mathesoncalum mathesoncalum approved these changes

Assignees

@Tantacrul Tantacrul

@DmitryArefiev DmitryArefiev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Note Input. MIDI keyboard input - Chords are entered as single notes; rests display incorrectly & can also mess up the remembered chord. Input By Duration: Adding accidentals when there's a key signature causes pitches to move to the wrong duration When using shortcuts, toggling between the regular and 'Input by duration' modes causes the pitch to disappear 'Rhythm only' input mode preserves the first entered pitch for the next notes, even if the previous note was modified with up/down arrows Input by duration cursor is cut off on Windows/Linux
Input By Duration: Accidentals are not displayed next to noteheads Input By Duration: When toggling rest mode, and toggling it off, the note head cursor disappears. Notes can't be entered. Input by duration, arrow through drum kit causes crash Input by duration: beat lines above staff only display correctly for 4/4 time "Input by duration" note input preference changes
6 participants
@RomanPudashkin @DmitryArefiev @Tantacrul @bkunda @avvvvve @mathesoncalum