Changed markup when using optgroup element

[lucascumsille]

Instead of using the pseudo element to display the title of a optgroup, now they will be wrapped on a fieldset with a legend. The legend will have the text from the label atrribute from the optgroup.

It's also possible to change the class names for the fieldset and legend, by using these settings: menuFieldsetHTML and menuFieldsetLegendHTML.

[dracos]

Some suggestions, let me know what you think. Also as mentioned elsewhere we'll need to make the up/down changes here (in e.g. the upDown function).

[lucascumsille]

@dracos Thanks for the feedback =), sorry I had a couple of extras from an experiment I was doing a couple of weeks ago. I added some fixups, that fixed all the issues above. I tried to make the up and down keys to work when using fieldset, but it didn't work at the end.

[dracos]

@lucascumsille I've pushed a commit that hopefully gets up/down working as before if you'd like to take a look. I've also fixed the tests.

[lucascumsille]

@dracos That's perfect is working for me. I tried it on Voiceover, and it works slightly different than the one we used to have, where on each option it would read = "Group title + option name" Example "Flavour Vanilla", now it gives the name of the group when you are in the first option of the group, which is exactly what happens with GOVUK and by default.

If we wanted to keep the current behaviour we could include an aria-label that reads "Flavour Vanilla", but I'm not sure if it's unnecessary, because screenreader users are already used to the default. At the same time I liked the fact that "Flavour Vanilla" provides context without the need of having good memory, but it can be a pain with long lists or fieldsets with long names.

Let me know what you think, otherwise I can just merge to master.

[dracos]

I think going with the default fieldset behaviour is probably more consistent, yeah - the category list on FMS map filter can be quite long, but OTOH will have a few fieldsets in it, but hopefully will be clear.

[lucascumsille]

@dracos Sounds good, let's keep it like that. Should I merge it master?

[dracos]

yeah, go for it, up to you if you want to merge the two commits as one or keep it as it is