[pull] master from getsentry:master #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…remove compile flag for feature (#678) In addition to removing the flag, this also touches several test files. This is because the removal of these flags has created several double imports of sentry.h primarily in the test suite, which causes compilation to fail.
This aggressively bumps black up to a new version to fix our linter jobs in CI. This is fine because the use of Python is exclusively confined to integration tests, which makes the impact of this update fairly small. This change also updates the CI to remove the job running tests on a Windows Server 2016 environment as it is now deprecated and can no longer be used. A job running the same tests on Windows Server 2019 has been created to replace the removed job, as `windows-latest` now uses Windows Server 2022.
… to char*s (#690) This tries to future-proof project IDs as they aren't guaranteed to be numbers forever. Project IDs are now treated as opaque strings, and minimal validation is now applied to them to reflect that fact.
This fixes #701 Signed-off-by: Vitalii Koshura <[email protected]>
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
…th docs (#729) processing sequence of sentry__capture_event() to align with the docs/spec (https://develop.sentry.dev/sdk/sessions/#filter-order).
…732) Previously the Windows ModuleFinder would early-return in case the loaded library had no debug directory / codeview record. In that case, the image type and code-id would be missing which results in normalization errors in Relay. We now always write the image type, and the code-id as early as possible.
- don't invoke before_send if on_crash is set - if on_crash returns false crash report will be discarded
* Added socks5_proxy to options * correct options freeing * Update CHANGELOG.md * Add socks5_proxy attribute to curl_transport_state * formatting * refactor to use single proxy attribute * format * Added back deprecated http_proxy API * formatting * refactor sentry_transport_winhttp.c to use opts->proxy * formatting * update crashpad dependency * fix: update minimum libcurl version check to 7.21.7 * update crashpad dependency * test: add proxy integration tests * get latest crashpad changes * feat: add example.c run-args for http and socks5 proxy * test: changed test name + added more mitmdump startup time * chore: format * test: add mitmproxy to requirements.txt * test: add skip for proxy test on non-MacOS platforms * test: move socksproxy-off assert into AssertionError check for Linux test * test: change expected http log length to match platform * test: order of operations * test: run http proxy tests on all platforms * test: add special case for Windows Autoproxy * apply suggestions from code review * chore: added comments about proxy behaviour * cleaned up test and moved comments to proper place (let's hope I didn't mess up CI) * chore: fix minor comment typo * chore: added api documentation * Update include/sentry.h Co-authored-by: Mischan Toosarani-Hausberger <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Mischan Toosarani-Hausberger <[email protected]> * update crashpad submodule * update crashpad submodule (again) * updated CHANGELOG.md * updated CHANGELOG.md again --------- Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
* updated readme * added link to C+20 requirement issue * Add build prerequisites into readme * Added additional link to Contributing.md * apply suggestion from code review Co-authored-by: Mischan Toosarani-Hausberger <[email protected]> * apply suggestions from code review --------- Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
* Extended API to allow explicit timings * Add tests for timestamped API functions * re-add todos and comments that went missing in refactoring * update changelog * update docstrings for new API * apply refactoring suggestion from code review * change assert_timestamp to be more accurate * cleanup unnecessary includes
* feat: add linux distributions to os context * Clean up test-allocations like a good boy * separate os-dependent unit-test sources * platform-specfic testing is decided in the translation-units * Exclude Android too * Add documented fallback * Ensure we exhausted the snapshot * DeMorgan * format * add valgrind exception for false positive when memmove is an ifunc resolving to memcpy * Make sure that distributions are only added in Linux not any Unix * Make sure we don't leak in the error paths * Clean up the fall-back from /etc/os-release to /usr/lib/os-release * attribute derivative work * apply PR feedback * Extract slice to buffer handling in a new sentry_slice_t function. * Make sure we can read a full line of max value and max key. This is a hugely hypothetical target, since the max values are far beyond all the test data we currently observed, but still. * fix classic buffer continuity bug. * extract parse_line_into_object... ...to separate parsing/output from buffer management. * ensure line update if we hit the buffer-end correctly. * add support for os-release files that don't end with a newline. * Add comments to the subtler buffer management aspects. * Add a list of tested distribution names for documentation * Add back eof-newline to valgrind exceptions. * Adapt test to new entry in fixture. * include sentry_utils in sentry_os only on Linux * Ensure we find close() in unistd.h by including it explicitly. * include sentry_utils in sentry_os on Windows too * use unistd.h in sentry_os only for Linux * flattened distribution payload fields * format * incref for get_by_key calls * decref no longer copied os_dist --------- Co-authored-by: JoshuaMoelans <[email protected]>
* Add options to set NDK handler strategy * Update Changelog
* feat: update crashpad submodule * update CHANGELOG.md * update CHANGELOG.md
* feat: add logger output level * remove test function * add separate init log level * refactor: rename of internal log macros * update CHANGELOG.md * applied feedback changing log macros * missed one F * remove overdesigned init log level * changelog update
* add traces_sampler option * update CHANGELOG.md * introduced `sentry_traces_sampler_function` typedef * added sampling context * format * eof newlines * feat: pass sampling_context into sampling decision * remove unnecessary commented include * add memory freeing/incref-decref * change custom sampling context type to sentry_value_t * add decref * removed unneeded creation function * format * set codeql runner to ubuntu-22.04 * take ownership of custom_sampling_ctx * add parent sampling decision * add traces_sampler and parent sampling decision tests * decref * change callback arg from struct to parameter list * format * mark unused parameters * format * cleanup test + docs * apply PR feedback * format * cleanup example * add getters for transaction_ctx name + operation * remove (void) on transaction_ctx in example.c * add transaction_ctx getter tests * dont expose sampling_context_s in sentry.h * change bool to int * cleanup example.c * refactor tx_cxt to tx_ctx convention * change sampled_int init --------- Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
* fix: build error introduced by `crashpad` C++17 support * introduce a GCC 9.4.0 runner * update dependencies for new runner * remove new runner from old deps * update crashpad * update crashpad * remove -Wno-gnu-include-next from senntry compile options * update crashpad * remove handle_ex target * update crashpad * remove gnu-include-next warnings only for non GNU compilers * disable pedantic on sentry_boot.h for sentry_info.c * reset werror for GCC until we fix the crashpad compat * fix typo Co-authored-by: JoshuaMoelans <[email protected]> * update crashpad --------- Co-authored-by: JoshuaMoelans <[email protected]>
#1122) * Prevent c4701 warning on windows arm * comment that init has no semantic meaning --------- Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
* fix: support PAC stripping on older assemblers. * update crashpad after squash-merge to getsentry branch
* Auto detect latest GDK and Windows SDK * Update changelog * Accept Suggestions and allow GDK override --------- Co-authored-by: PlasmaDev5 <[email protected]> Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )