refactor(core): Decouple user events from internal hooks (no-changelog) #10292
Conversation
n8n-assistant
bot
added
core
| @@ -101,7 +99,6 @@ export class MeController { | |||
| this.authService.issueCookie(res, user, req.browserId); | |||
|
|
|||
| const fieldsChanged = Object.keys(payload); | |||
| this.internalHooks.onUserUpdate({ user, fields_changed: fieldsChanged }); | |||
There was a problem hiding this comment.
Pre-existing bug: Even when updating a single field, all fields exist in the payload, so all fields are being reported as having changed. To be fixed separately.
There was a problem hiding this comment.
Do we have a follow-up for that?
There was a problem hiding this comment.
I'll follow up on this, won't forget
| this.internalHooks.onUserRoleChange({ | ||
| user: req.user, | ||
| target_user_id: targetUser.id, | ||
| target_user_new_role: ['global', payload.newRoleName].join(' '), |
There was a problem hiding this comment.
Pre-existing bug: The target user's new role is being reported e.g. as 'global global:member'. To be fixed separately.
There was a problem hiding this comment.
Do we have a followup for this?
There was a problem hiding this comment.
I'll follow up on this, won't forget
| @@ -101,7 +99,6 @@ export class MeController { | |||
| this.authService.issueCookie(res, user, req.browserId); | |||
|
|
|||
| const fieldsChanged = Object.keys(payload); | |||
| this.internalHooks.onUserUpdate({ user, fields_changed: fieldsChanged }); | |||
There was a problem hiding this comment.
Do we have a follow-up for that?
| this.internalHooks.onUserRoleChange({ | ||
| user: req.user, | ||
| target_user_id: targetUser.id, | ||
| target_user_new_role: ['global', payload.newRoleName].join(' '), |
There was a problem hiding this comment.
Do we have a followup for this?
|
✅ All Cypress E2E specs passed |
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
* master: feat(editor): Auto-add LLM chain for new LLM nodes on empty canvas (#10245) fix(core): Fix user telemetry bugs (#10293) refactor(core): Remove stray log from telemetry event relay (no-changelog) (#10295) refactor(core): Decouple user events from internal hooks (no-changelog) (#10292) feat(core): Support community packages in scaling-mode (#10228) test(core): Move unit tests closer to testable components (no-changelog) (#10287) fix(core): Webhook and form baseUrl missing (#10290) refactor(core): Port cache config (no-changelog) (#10286)
|
Got released with |
Follow-up to: #10280