refactor(core): Decouple lifecycle events from internal hooks (no-changelog) #10305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
ivov
commented
Aug 6, 2024
tomi
previously approved these changes
Aug 7, 2024
|
✅ All Cypress E2E specs passed |
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||
tomi
reviewed
Aug 7, 2024
packages/cli/src/telemetry/index.ts
Outdated
| @@ -167,11 +168,10 @@ export class Telemetry { | |||
| } | |||
| } | |||
|
|
|||
| async trackN8nStop(): Promise<void> { | |||
| @OnShutdown() | |||
There was a problem hiding this comment.
We have different priorities for shutting down. Is it by default in the "last" group? If not, let's add a priority that makes it shut down last
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: #10292