feat(Summarize Node): Preserves original field data type #12999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
n8n team
ShireenMissi
reviewed
Feb 4, 2025
| @@ -287,3 +288,38 @@ export function aggregationToArray( | |||
| return returnData; | |||
| } | |||
| } | |||
|
|
|||
| export function aggregationToArrayWithOriginalTypes( | |||
There was a problem hiding this comment.
This function is too similar to aggregationToArray, I suggest you reuse the repeated parts to avoid code duplication
There was a problem hiding this comment.
Thanks Shireen! Added a few changes. Let me know if this is what you had in mind :)
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-1572-summarize-node-fields-to-split-by-are-cast-to-strings
|
| Run status |
|
| Run duration | 04m 18s |
| Commit |
|
| Committer | Ria |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
381
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
39-projects.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Projects > when starting from scratch > should move resources between projects |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 22 specs in Cypress Cloud.
|
|
riascho
force-pushed
the
node-1572-summarize-node-fields-to-split-by-are-cast-to-strings
branch
from
5fd66ca to
159b51d
Compare
…g a specific version (#12840) Co-authored-by: Iván Ovejero <[email protected]>
…ues in local storage (#13025) Co-authored-by: Csaba Tuncsik <[email protected]>
…using out of date inputs (#13008)
riascho
deleted the
node-1572-summarize-node-fields-to-split-by-are-cast-to-strings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously the
Summarize Nodewould convert the data type of an input value to be used for grouping into a string. This PR introduces type preservation for numeric and null values infieldToSplitBy.v1v1.1Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1572/summarize-node-fields-to-split-by-are-cast-to-strings
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)