Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do Junos and EOS drivers allow for SSH host-key validation and SSL cert validation #901

Open
ktbyers opened this issue Jan 7, 2019 · 3 comments
Open

Do Junos and EOS drivers allow for SSH host-key validation and SSL cert validation #901

ktbyers opened this issue Jan 7, 2019 · 3 comments
Labels
eos investigation junos
Milestone
APPROVED

Comments

@ktbyers
Copy link
Contributor

ktbyers commented Jan 7, 2019

I didn't see the arguments in optional_args to enable this in napalm driver.
@bewing
Copy link
Member

bewing commented Jan 7, 2019

pyeapi disables SSL verification if an SSL context is not passed in:

https://github.com/arista-eosplus/pyeapi/blob/develop/pyeapi/eapilib.py#L542-L545

Unfortunately, the pyeapi.client.connect method does not expose this. It could be, if we switched to using pyeapi.client.make_connection instead, but we'd still need to pass in the kwargs correctly.

bewing added a commit that referenced this issue Jan 7, 2019
@bewing
Refactor processing of EOS optional_args (#901)
f64e3e9 
Process optional_args in a way that supports arbitrary underlying
arguments in the connection class used.
bewing added a commit that referenced this issue Jan 7, 2019
@bewing
Refactor processing of EOS optional_args (#901)
67a25ba 
Process optional_args in a way that supports arbitrary underlying
arguments in the connection class used.
ktbyers pushed a commit that referenced this issue Jan 8, 2019
@bewing @ktbyers
Refactor processing of EOS optional_args (#901) (#902)
168f456 
Process optional_args in a way that supports arbitrary underlying
arguments in the connection class used.
@bewing
Copy link
Member

bewing commented Jun 12, 2019

This is exposed in EOS now, in release 2.4.0

@mirceaulinic mirceaulinic added this to the APPROVED milestone Sep 17, 2019
ExaneServerTeam pushed a commit to ExaneServerTeam/napalm that referenced this issue Mar 6, 2020
@bewing @ExaneServerTeam
Refactor processing of EOS optional_args (napalm-automation#901) (nap…
7537e08 
…alm-automation#902)

Process optional_args in a way that supports arbitrary underlying
arguments in the connection class used.
@bewing
Copy link
Member

bewing commented Jan 23, 2023

@ktbyers does

napalm/napalm/junos/junos.py

Line 90 in 9b66011

self.ssh_config_file = optional_args.get("ssh_config_file", None)
fulfill the JunOS SSH host-key validation knob well enough to close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
eos investigation junos
Projects
None yet
Milestone
APPROVED
Development

No branches or pull requests
3 participants
@ktbyers @bewing @mirceaulinic