Refactor processing of EOS optional_args (#901) #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process optional_args in a way that supports arbitrary underlying arguments in the connection class used.
2 similar comments
|
@bewing I assume you sanity tested this against a real device and the connection process still works properly? I reviewed the code and that looked right. |
|
I have performed basic testing of the change against 7280's and 7150s. Running the non-mock test suite shows no new failures with this change, but have provided a whole new rabbithole for me to go down. |
ktbyers
approved these changes
Jan 8, 2019
ExaneServerTeam
pushed a commit
to ExaneServerTeam/napalm
that referenced
this pull request
Mar 6, 2020
…alm-automation#902) Process optional_args in a way that supports arbitrary underlying arguments in the connection class used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process optional_args in a way that supports arbitrary underlying
arguments in the pyeapi connection class used.