Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node.js and npm version requirements #415

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

albinazs
Copy link
Contributor

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.

Description

Add Node.js and npm version requirements to package.json file, mirroring www.front-end project. This will help to avoid overlooking incorrect engines versions and prevent potential compatibility issues.

Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @albinazs! Considering we do this on other projects, I think this will help quite a bit. Particularly since the project relies on the older package-lock.json format.

@albinazs albinazs marked this pull request as ready for review August 16, 2023 11:37
@albinazs albinazs requested a review from Scotchester August 16, 2023 11:37
@albinazs
Copy link
Contributor Author

@Scotchester ready for review

@Scotchester Scotchester added maintenance The meta work of maintaining the project patch Contains bug fixes or maintenance work and removed feature labels Aug 16, 2023
@albinazs albinazs merged commit 3f072df into main Aug 16, 2023
@albinazs albinazs deleted the feature/engines-requirements branch August 16, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance The meta work of maintaining the project patch Contains bug fixes or maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants