Fix #54, Add EDS file for BP #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a draft as it depends on other changes that are not yet merged. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jphickey
force-pushed
the
fix-54-add-eds
branch
from
e65bc40 to
7771d71
Compare
dzbaker
added
ccb:provisionally-approved
Add EDS XML file and integrations
jphickey
force-pushed
the
fix-54-add-eds
branch
from
bf6da31 to
c4bd6cd
Compare
|
Rebased now that dependencies are resolved. |
dzbaker
added
ccb:approved
jphickey
added a commit
to jphickey/bp
that referenced
this pull request
Jan 17, 2024
The change to event IDs was not picked up by automatic rebase and resulted in a name mismatch. This updates the event IDs in the EDS dispatch file to match.
dzbaker
added a commit
that referenced
this pull request
Jan 17, 2024
HotFix #55, correct Event IDs in dispatch table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Initial integration of the EDS file for BP app
Testing performed
Build and run BP with EDS framework, test file transfer
Expected behavior changes
An authoritative and concise CMD/TLM definition is available
System(s) tested on
Debian
Additional context
BP still builds and runs without EDS integration, if so desired.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.