Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #50, implement dispatcher pattern for BP #51

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

jphickey
Copy link
Collaborator

@jphickey jphickey commented Dec 7, 2023

Describe the contribution
Split command handler implementations and dispatching operation to separate source files.

Fixes #50

Testing performed
Run all tests

Expected behavior changes
None

System(s) tested on
Debian

Additional context
Source code organizational change only, no real logic change.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

fsw/src/bp_dispatch.h Fixed Show fixed Hide fixed
fsw/src/bp_dispatch.c Fixed Show fixed Hide fixed
fsw/src/bp_dispatch.c Fixed Show fixed Hide fixed
fsw/src/bp_dispatch.c Fixed Show fixed Hide fixed
fsw/src/bp_dispatch.c Fixed Show fixed Hide fixed
@jphickey jphickey requested a review from sjonke December 7, 2023 22:01
@jphickey jphickey added the ccb:ready Pull request is ready for review label Dec 13, 2023
@jphickey jphickey force-pushed the fix-50-dispatcher branch 3 times, most recently from 397d35e to bbd35f5 Compare December 14, 2023 14:52
Copy link
Collaborator

@sjonke sjonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment issue. Otherwise looks good.

fsw/src/bp_dispatch.c Outdated Show resolved Hide resolved
Split command handler implementations and dispatching operation to
separate source files.
@dzbaker dzbaker added ccb:approved Pull request has been reviewed and approved for merging and removed ccb:ready Pull request is ready for review labels Jan 11, 2024
@dzbaker dzbaker merged commit 680b4b9 into nasa:main Jan 11, 2024
5 checks passed
@jphickey jphickey deleted the fix-50-dispatcher branch January 17, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ccb:approved Pull request has been reviewed and approved for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split command handlers from app and implement "dispatcher" pattern
3 participants