C++ code generation for telemetry packets #632
Conversation
Add tlm packets
PacketsAc --> TlmPacketsAc
Add header includes for tlm packets
| telemetry packets P1 { | ||
|
|
||
| packet P1 group 4 { | ||
| M.c1.T1 | ||
| M.c1.T2 | ||
| M.c1.T3 | ||
| M.c1.T4 | ||
| M.c1.T5 | ||
| M.c1.T6 | ||
| } | ||
|
|
||
| } omit { | ||
| M.c2.T1 | ||
| M.c2.T2 | ||
| M.c2.T3 | ||
| M.c2.T4 | ||
| M.c2.T5 | ||
| M.c2.T6 | ||
| } |
There was a problem hiding this comment.
The codegen looks good though I am confused about the purpose of omit. This block seems a bit counter-intuitive since it's omiting all the channels it put in the group. Reading https://github.com/nasa/fpp/blob/main/docs/spec/Specifiers/Telemetry-Packet-Set-Specifiers.adoc did not clarify the purpose of omit
There was a problem hiding this comment.
The codegen looks good though I am confused about the purpose of
omit. This block seems a bit counter-intuitive since it'somiting all the channels it put in the group. Reading https://github.com/nasa/fpp/blob/main/docs/spec/Specifiers/Telemetry-Packet-Set-Specifiers.adoc did not clarify the purpose ofomit
In this case, there are multiple component instances. Component instance c1’s channels are included in the telemetry packet and we’re only omitting component instance c2’s channels from the packet.
Closes #567.