Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pitfilling and D8 flow direction progress logging displays integer overflow on large rasters #246

Closed
phargogh opened this issue Mar 15, 2022 · 0 comments · Fixed by #351
Closed

Pitfilling and D8 flow direction progress logging displays integer overflow on large rasters #246

phargogh opened this issue Mar 15, 2022 · 0 comments · Fixed by #351
Assignees
@phargogh
Labels
bug Something isn't working in progress Working on it!

Comments

@phargogh
Copy link
Member

This came up on the forums recently (https://community.naturalcapitalproject.org/t/questions-about-running-delineatelt/2577/1). You can see from the screenshots that on very large DEMs, we're getting an integer overflow when tracking the total number of pixels that should be able to be resolved with a higher-memory counter int, maybe even an unsigned int.

We should take a look at all of the progress logging in routing.pyx to see if there are any other functions where this should be updated as well.
@phargogh phargogh changed the title Pitfilling and D8 flow direction has buggy progress logging in large rasters Pitfilling and D8 flow direction progress logging displays integer overflow on large rasters Mar 15, 2022
@phargogh phargogh added the bug Something isn't working label Mar 15, 2022
@phargogh phargogh self-assigned this Sep 25, 2023
@phargogh phargogh added the in progress Working on it! label Sep 25, 2023
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Sep 25, 2023
@phargogh
Making a bunch of signed integers in routing unsigned longs.
2e705ec 
This will avoid issues with extremely large rasters at the cost of
potentially double the memory usage.

RE:natcap#350
RE:natcap#246
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Sep 25, 2023
@phargogh
Allocating more memory to ints throughout routing.
4faf8d5 
RE:natcap#350
RE:natcap#246
@phargogh phargogh mentioned this issue Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
bug Something isn't working in progress Working on it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve int memory usage throughout routing phargogh/pygeoprocessing
1 participant
@phargogh