Don't immediately throw in ConstructorInjectionConvention #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather let the ModelFactory throw as the convention is applied twice in hosting case.
It took me some time to discover why the unit-test of my pull-request #178 started failing. I immediately suspected #175, but it took me an hour to realize that the convention is immediately applied when added to the builder. Worse: in CommandLineService it is applied twice!
By setting the ModelFactory to a throw-implementation we get to the second invocation were we set up the real deal. Effect for other apps is that the exceptions are a bit later, but also less nested. This also gives room for other conventions to set-up ModelFactories.