Model injecting convention #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheConstructor
force-pushed
the
feature/inject-model
branch
from
9bfe842 to
ac069bf
Compare
TheConstructor
changed the title
TheConstructor
force-pushed
the
feature/inject-model
branch
from
ac069bf to
4e58c6f
Compare
TheConstructor
force-pushed
the
feature/inject-model
branch
from
4e58c6f to
acd52c1
Compare
|
So, thanks for the PR. I think I need a little more convincing on this one. Can you share an example of a problem this solves? It seems like this might be possible to avoid adding a new convention and make improvements to ConstructorInjectionConvention instead. |
|
If you don't feell good about it, just reject it. It was mostly meant to show that throwing while applying ConstructorInjectionConvention blocks the path for other model-factories. This IConvention can easily be recreated by applications in need of it and might help with more complex constructors.. |
|
Ok, I'm going to close for now. If you want to revisit in the future, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would enable models to be externally provided.
This depends on #181 and currently lacks tests and an extension-method on ConventionBuilder hence WIP.