Adds a number of helper structs for z responses #6249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
force-pushed
the
z_response_types
branch
from
211fe47 to
fc974bb
Compare
|
These types doesn't exist anywhere its constructed from a So to use them everyone either have to double json decode (This is how MH designed it and insisted its used) or write these structs themselves, so this just helps out. |
|
ok let's comment why they are here and not used in any of the server code base just for clairity. |
These are used by the cli and other tools to decode the responses from the z endpoints Signed-off-by: R.I.Pienaar <[email protected]>
ripienaar
force-pushed
the
z_response_types
branch
from
fc974bb to
8841131
Compare
Have clarified the comment that was there already a bit further |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used by the cli and other tools to decode the responses from the z endpoints
Signed-off-by: R.I.Pienaar [email protected]