Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-flake TestNRGSimple #6266

Merged
merged 1 commit into from
Dec 16, 2024
Merged

De-flake TestNRGSimple #6266

merged 1 commit into from
Dec 16, 2024
+4 −4

Conversation

MauriceVanVeen
Copy link
Member

TestNRGSimple was not actually testing anything, as proposeDelta asynchronously proposes the changes so the waitOnTotal would immediately pass even if none of the proposals went through (or even if proposeDelta was commented out).

Signed-off-by: Maurice van Veen [email protected]

@MauriceVanVeen
De-flake TestNRGSimple
1b39642 
Signed-off-by: Maurice van Veen <[email protected]>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner December 16, 2024 14:33
derekcollison
derekcollison approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit acd7e3c into main Dec 16, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/de-flake-nrg-simple branch December 16, 2024 15:22
@neilalexander neilalexander mentioned this pull request Dec 16, 2024
Merged
neilalexander added a commit that referenced this pull request Dec 16, 2024
@neilalexander
Cherry-picks for 2.10.24-RC.3 (#6268)
4e7b79b 
Includes the following:

- #6260
- #6249
- #6264
- #6265
- #6266

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MauriceVanVeen @derekcollison