Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠ Remove feature flags #791

Closed
lorenyu opened this issue Nov 25, 2024 · 0 comments · Fixed by #790
Closed

⚠ Remove feature flags #791

lorenyu opened this issue Nov 25, 2024 · 0 comments · Fixed by #790
Assignees
@coilysiren
Labels
scope: service Service layer / component type: bug Something isn't working

Comments

@lorenyu
Copy link
Contributor

lorenyu commented Nov 25, 2024

This change removes feature flags. Evidently is deprecated and it's also causing template CI to break.
We don't yet have a replacement solution in mind, so for now we are just going to remove the feature flag feature.

Note that this change will be a breaking change and will need migration instructions in the release notes.
@lorenyu lorenyu added scope: service Service layer / component type: bug Something isn't working labels Nov 25, 2024
@lorenyu lorenyu linked a pull request Nov 25, 2024 that will close this issue
⚠ Removes feature flags #790
Merged
This was referenced Nov 27, 2024
Closed
Merged
coilysiren added a commit that referenced this issue Nov 27, 2024
@coilysiren
Removes feature flags (#790)
94b4dd0 
## Ticket

Relates to #781

Closes #791

## Changes

- removes evidently from the infrastructure layer
- removes evidently from the application layer

## Testing

navapbc/platform-test#142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coilysiren coilysiren

Labels
scope: service Service layer / component type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚠ Removes feature flags navapbc/template-infra
2 participants
@lorenyu @coilysiren