[Timeline]: Earliest date defaulted to current date when found date was later than current day #3458
Conversation
🦋 Changeset detectedLatest commit: f381fae The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demo603ccef14 | 91 komponenter | 135 stories |
| ); | ||
|
|
||
| return earliestDate; | ||
| }, [startDate, rows]); |
There was a problem hiding this comment.
The useMemo in useEarliestDate seems to be running on every render. I think it's because of rows. We can fix it later since it wasn't added in this PR, but I think we should reconsider all use of useMemo in this component.
There was a problem hiding this comment.
Is this potentially something that we can just delete entirely when we have upgraded to react 19 and decided to use the compiler... 🤔 (and the compiler should be able to optimise re-renders?)
Actually, I don't think it will make sense for a design system to "use the react compiler" (we wouldn't be able to use it on behalf of our consumers 😅 ), so nvm this.
Co-authored-by: Halvor Haugan <[email protected]>
Description
Resolves #3457
In short, if earliest date found was "1 jan 2027" and current date is "1 jan 2024" the returned date was "1 jan 2024". This was caused by the "default"-value in reduce being
new Date()Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")