Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Timeline]: Earliest date defaulted to current date when found date was later than current day #3458
[Timeline]: Earliest date defaulted to current date when found date was later than current day #3458
Changes from 2 commits
5b83238
32280cc
c4ba9cd
1928dab
f381fae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
useMemo
inuseEarliestDate
seems to be running on every render. I think it's because ofrows
. We can fix it later since it wasn't added in this PR, but I think we should reconsider all use ofuseMemo
in this component.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this potentially something that we can just delete entirely when we have upgraded to react 19 and decided to use the compiler... 🤔 (and the compiler should be able to optimise re-renders?)Actually, I don't think it will make sense for a design system to "use the react compiler" (we wouldn't be able to use it on behalf of our consumers 😅 ), so nvm this.