Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

What if we used tabs, though? #65

Merged
merged 4 commits into from
Aug 20, 2022
Merged

What if we used tabs, though? #65

merged 4 commits into from
Aug 20, 2022

Conversation

zkxs
Copy link
Collaborator

@zkxs zkxs commented Aug 20, 2022

Changes everything to tabs. Removes human-readable whitespace guidelines from CONTRIBUTING.md as they are superseded by editorconfig.

dotnet format doesn't run on csproj or sln files so I've formatted them manually.

THE PRS WILL CONTINUE
UNTIL MORALE IMPROVES

@zkxs zkxs requested review from ljoonal and EIA485 August 20, 2022 18:11
Copy link
Member

@EIA485 EIA485 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, 4 spaces are also fine if it really matters

Copy link
Member

@ljoonal ljoonal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To note since the previous PR was conserned about github rendering tabs as 8 spaces, that's configurable:

Github tab size settings

@EIA485
Copy link
Member

EIA485 commented Aug 20, 2022

if its configurable then this seems to be the best option, it can make everyone happy with their visual preference

@zkxs zkxs merged commit 321ac86 into master Aug 20, 2022
@zkxs
Copy link
Collaborator Author

zkxs commented Aug 20, 2022

The people have spoken, and they are least bothered by tabs.

@EIA485 EIA485 deleted the whitespace-was-a-mistake branch August 22, 2022 23:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants