Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

What if we used 4 spaces, though? #66

Closed
wants to merge 6 commits into from
Closed

Conversation

zkxs
Copy link
Collaborator

@zkxs zkxs commented Aug 20, 2022

Changes everything (back) to four spaces. Removes human-readable whitespace guidelines from CONTRIBUTING.md as they are superseded by editorconfig.

dotnet format doesn't run on csproj or sln files so I've formatted them manually.

THE PRS WILL CONTINUE
UNTIL MORALE IMPROVES

zkxs added 6 commits August 19, 2022 15:27

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani
…em manually

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani
@zkxs zkxs requested review from EIA485 and l-2-j and removed request for EIA485 August 20, 2022 18:17
Copy link
Member

@EIA485 EIA485 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. if tabs really cause issues then im happy to go with 4 spaces

Copy link
Member

@l-2-j l-2-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 Spaces is a bit too much for me. Though if everyone else wants it I'm not going to stop the PR by requesting changes either.

@EIA485
Copy link
Member

EIA485 commented Aug 20, 2022

#65 seems to be the best option as it allows you to change the visual based on your preference within your editor

@zkxs
Copy link
Collaborator Author

zkxs commented Aug 20, 2022

#65 is the ultimate winner.

@zkxs zkxs closed this Aug 20, 2022
@EIA485 EIA485 deleted the go-back-i-want-to-be-monkey branch August 22, 2022 23:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants