Skip to content

Commit

Permalink
TASK: Remove Flow's RequestInterface
Browse files Browse the repository at this point in the history
TLTR:

Since the separation of http and cli requests the interface is completely unused. And strict types against its only implementation, the ActionRequest make it impossible to implement a custom request.

--------

_Initially_ the interface was introduced with 2a26925 at beginning of time. At that time this was done probably to be able to type against the interface instead of the common `Request` class, that the Cli and Web Request both extended.

With the removal of many methods in its interface 8c40ff2 and with the full separation of action and cli requests #1552 the interface became useless.

The dispatcher and controller interface are both typed against the `ActionRequest` and so it's impossible to implement a custom request.
  • Loading branch information
mhsdesign committed Mar 3, 2024
1 parent 15ede86 commit c16cb13
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 68 deletions.
2 changes: 1 addition & 1 deletion Neos.Flow/Classes/Mvc/ActionRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
*
* @api
*/
class ActionRequest implements RequestInterface
class ActionRequest
{
/**
* @Flow\Inject
Expand Down
67 changes: 0 additions & 67 deletions Neos.Flow/Classes/Mvc/RequestInterface.php

This file was deleted.

0 comments on commit c16cb13

Please sign in to comment.