!!!TASK: Remove deprecated Http objects and replace with PSR-7 implementation #1552

albe · 2019-04-19T20:54:13Z

This replaces the HTTP stack of Flow with PSR-7.

Many areas of Flow are affected by this, most notably and breaking:

All HTTP is now fully PSR-7
Response in MVC controllers is no longer an HTTP response and has very different methods.
CLI and MVC use different dispatchers now
ActionRequest::getParentRequest() will return null at the top instead of an HttpRequest, you can still get the HttpRequest via ActionRequest::getHttpRequest()
ActionRequest::fromHttpRequest(ServerRequestInterface $httpRequest) introduced
ActionRequest::createSubRequest() introduced
ActionRequest can longer be created via new
\Neos\Flow\Mvc\ActionRequestFactory introduced to correctly merge arguments from the HTTP request
Neos.Http.Factories introduced, implementing PSR-17 HTTP factories, use those to create and fake HTTP requests
The HTTP process was split into more components to have easier extension points in between. So you can interject between the creation of the top level ActionRequest (after which security is avaliable) and the actual dispatching to a controller

Related: #658

Example API Changes:

no more Mvc\Response, instead ActionRequest and ActionResponse are the API inside the MVC stack
to create an ActionRequest, use the ActionRequestFactory->createActionRequest($serverRequest, $arguments)
inside a Controller:
- $this->response->setHeader('Content-Type', ...) -> $this->response->setContentType(...)
- $this->response->setHeader('Location', ...) -> $this->response->setRedirectUri(...)
- $this->response->setStatus(...) -> $this->response->setStatusCode(...)
- $this->response->setHeader(...) -> $this->response->setComponentParameter(SetHeaderComponent::class, ...)
Request::create(...) -> new ServerRequest('GET', ...)
$httpRequest->getBaseUri() -> $httpRequest->getAttribute(ServerRequestAttributes::BASE_URI)

…ation

Neos.Flow/Classes/Http/Client/CurlEngine.php

Neos.Flow/Classes/Http/Client/InternalRequestEngine.php

Neos.Flow/Classes/Http/Component/ComponentContext.php

Neos.Flow/Classes/Http/Helper/RequestInformationHelper.php

Neos.Flow/Classes/Http/RequestHandler.php

Neos.Flow/Classes/Mvc/DispatchComponent.php

Neos.Flow/Configuration/Objects.yaml

Neos.FluidAdaptor/Classes/Core/Widget/AjaxWidgetComponent.php

kitsunet · 2019-04-26T11:44:19Z

OK, I totally missed this change and basically started the same in parallel. I will try to rebase my work on top of this, as I have a couple of changes that are not in here yet. We might want to discuss the Factories. I currently do not use them.

albe · 2019-04-28T14:39:53Z

Thanks for the feedback! Yes, let's discuss things. Just hit me on slack sometime this week.

This is a pretty early status and I only got the first tests pass again as easily as possible, by jumping on the Request::create* stuff to avoid rewriting all those tests. This is not how it should be ofc. If you manage to rebase your work on this or merge them together, that would be awesome!

kitsunet · 2019-04-29T09:25:54Z

There we go, tests will not run fully, but should be a step in the right direction. One thing to discuss is default SERVER vars as they know get applied with our request. That breaks a bunch of tests at the moment and I am not 100% sure how to fix this. Potentially could be fixed in the ServerRequestFactory but \o/ not sure

In general I didn't use the factories because in the request handler we are bound to a specific implementation anyways. It's nice to have for other components though.

albe

Some feedback

Neos.Flow/Classes/Http/Component/BaseUriComponent.php

Neos.Flow/Classes/Http/Client/Browser.php

Neos.Flow/Classes/Http/Component/TrustedProxiesComponent.php

Neos.Flow/Classes/Http/Request.php

Neos.Flow/Classes/Mvc/DispatchComponent.php

Neos.Flow/Classes/Mvc/Routing/RouterCachingService.php

Neos.FluidAdaptor/Tests/Functional/View/StandaloneViewTest.php

Neos.Flow/Classes/Mvc/DispatchComponent.php

Neos.Flow/Classes/Http/Component/ComponentInterface.php

kitsunet · 2019-05-05T12:39:13Z

Neos.Flow/Classes/Http/Component/RequestBodyParsingComponent.php

@@ -32,6 +32,9 @@ class RequestBodyParsingComponent implements ComponentInterface
    public function handle(ComponentContext $componentContext)
    {
        $httpRequest = $componentContext->getHttpRequest();
+        if (!empty($httpRequest->getParsedBody())) {


I have to check how we handled this before, but Guzzle ServerRequset::fromGlobals() sets $_POST as parsedBody, so if it was a "normal" POST request the parsed body will be fine already at this point.

Before we just merged $_POST into arguments on Request creation and kept the request body around until we parsed it when mapping arguments for the ActionController. Guzzle is more correct in assigning the POST as parsed Body, if it exists. It's just a PHP inbuilt request body parsing for multipart/form-data/application/x-www-form-urlencoded after all (which apparently only works for POST requests but e.g. not PUT).

Neos.Flow/Classes/Mvc/Routing/Dto/UriConstraints.php

Neos.Flow/Classes/Mvc/Routing/RoutingComponent.php

Neos.Flow/Tests/FunctionalTestRequestHandler.php

albe

A bit of feedback. Generally, this isn't as weird as I thought, but it brings up a couple of locations, where our current logic is lacking, because we end up invoking ->render() and completely ignoring the return value.

Neos.Flow/Classes/Mvc/ActionReponseRendererInterface.php

Neos.Flow/Classes/Mvc/ActionRequestFromHttpTrait.php

Neos.Flow/Classes/Mvc/ActionResponse.php

Neos.Flow/Classes/Mvc/ActionResponseRenderer/IntoComponentContext.php

Neos.FluidAdaptor/Classes/Core/Widget/AbstractWidgetViewHelper.php

Neos.FluidAdaptor/Classes/ViewHelpers/Widget/AutocompleteViewHelper.php

Neos.FluidAdaptor/Classes/ViewHelpers/Widget/PaginateViewHelper.php

Neos.FluidAdaptor/Tests/Functional/Core/Fixtures/ViewHelpers/RedirectViewHelper.php

kitsunet · 2019-08-15T19:56:54Z

Alright, more tomorrow, I am done for today...

kitsunet

Proxy review.

kitsunet · 2019-08-16T14:11:36Z

I restored the branch just in case.... with such a big change you never know...

Previously the `Dispatcher` invoked the `startAuthentication()` method of all authenticated tokens. That behavior was changed by accident with neos#1552 and now only the first Entry Point was triggered.

Not to be confused with the psr requests interface. TLTR: Since the separation of http and cli requests the interface is completely unused. And strict types against its only implementation, the ActionRequest make it impossible to implement a custom request. _Initially_ the interface was introduced with neos@2a26925 at beginning of time. At that time this was done probably to be able to type against the interface instead of the abstract `Request` class, that the Cli and Web Request both extended. With the removal of many methods in its interface neos@8c40ff2 and with the full separation of action and cli requests neos#1552 the interface became useless. The dispatcher and controller interface are both typed against the `ActionRequest` and so it's impossible to implement a custom request.

TLTR: Since the separation of http and cli requests the interface is completely unused. And strict types against its only implementation, the ActionRequest make it impossible to implement a custom request. -------- _Initially_ the interface was introduced with 2a26925 at beginning of time. At that time this was done probably to be able to type against the interface instead of the common `Request` class, that the Cli and Web Request both extended. With the removal of many methods in its interface 8c40ff2 and with the full separation of action and cli requests #1552 the interface became useless. The dispatcher and controller interface are both typed against the `ActionRequest` and so it's impossible to implement a custom request.

TLTR: Since the separation of http and cli requests the interface is completely unused. And strict types against its only implementation, the ActionRequest make it impossible to implement a custom request. -------- _Initially_ the interface was introduced with neos/flow-development-collection@39b8f80 at beginning of time. At that time this was done probably to be able to type against the interface instead of the common `Request` class, that the Cli and Web Request both extended. With the removal of many methods in its interface neos/flow-development-collection@8ab6a29 and with the full separation of action and cli requests neos/flow-development-collection#1552 the interface became useless. The dispatcher and controller interface are both typed against the `ActionRequest` and so it's impossible to implement a custom request.

TASK: Remove deprecated Http objects and replace with PSR-7 implement…

579435b

…ation

albe commented Apr 19, 2019

View reviewed changes

albe mentioned this pull request Apr 20, 2019

BUGFIX: Throw exception when passing objects to Headers::set() #1140

Closed

Adjust modifications and add PSR-15 package

80c317b

kitsunet changed the title ~~TASK: Remove deprecated Http objects and replace with PSR-7 implementation~~ !!!TASK: Remove deprecated Http objects and replace with PSR-7 implementation Apr 29, 2019

albe commented Apr 30, 2019

View reviewed changes

kitsunet added 2 commits May 2, 2019 10:24

More component split up

2bf493e

Cleanup Http components

0303d82

kitsunet reviewed May 2, 2019

View reviewed changes

Neos.Flow/Classes/Mvc/DispatchComponent.php Outdated Show resolved Hide resolved

kitsunet added 3 commits May 2, 2019 15:25

SERVER defaults and header extraction in ServerRequestFactory

13afc99

Add merging of ActionRequests via Renderer

d989ce4

Fix style errors

de87179

kitsunet reviewed May 5, 2019

View reviewed changes

Neos.Flow/Classes/Http/Component/ComponentInterface.php Outdated Show resolved Hide resolved

kitsunet reviewed May 5, 2019

View reviewed changes

Neos.Flow/Classes/Mvc/Routing/Dto/UriConstraints.php Outdated Show resolved Hide resolved

kitsunet reviewed May 5, 2019

View reviewed changes

Neos.Flow/Classes/Mvc/Routing/RoutingComponent.php Outdated Show resolved Hide resolved

kitsunet reviewed May 5, 2019

View reviewed changes

Neos.Flow/Tests/FunctionalTestRequestHandler.php Outdated Show resolved Hide resolved

albe commented May 5, 2019

View reviewed changes

kitsunet added 2 commits May 5, 2019 20:05

Small fixes and refinements

ffe8057

Move FlowUploadedFile and streamline argument merging

cce89d5

kitsunet mentioned this pull request May 9, 2019

!!!TASK: Adapt to PSR-7 HTTP separation neos/neos-development-collection#2485

Merged

kitsunet and others added 6 commits May 9, 2019 17:07

Get rid of inheritance in ActionReponse nad adjust everything

c353598

Fix style issues

c587e08

TASK: Some small fixes

d4606fc

TASK: Some more changes

4184fc8

TASK: Fix a couple of tests

bb38fe1

TASK: Some more cleanup and refactoring

9561d7f

kitsunet added 2 commits August 15, 2019 21:26

Adjust ActionResponse creation and parent request handling

e2eb5a3

Fix error with dispatcher and AuthenticationRequiredException

693c518

kitsunet added 7 commits August 16, 2019 09:22

More psalm and type safety fixes

5b94c18

Psalm and type safety fixes

cd2834d

More type safety fixes

e2b5b84

Unit test fixes and type fixes

a8ef2fd

Psalm and test fixes

67c865e

Fix issues with template lookups

8961bf2

Fix template path resolving

4ec2b5c

kitsunet approved these changes Aug 16, 2019

View reviewed changes

kitsunet merged commit e2f21c0 into neos:master Aug 16, 2019

kitsunet deleted the http-psr7 branch August 16, 2019 14:11

kitsunet restored the http-psr7 branch August 16, 2019 14:11

This was referenced Aug 20, 2019

FEATURE: Add getBaseUri() getter to ActionRequest #1716

Closed

Cookie-Handling with PSR-7 #1722

Closed

bwaidelich mentioned this pull request Aug 23, 2019

BUGFIX: Trigger Entry Points of all authenticated tokens #1729

Merged

albe mentioned this pull request Sep 18, 2020

persistAll() with true can lead to weird error messages on CLI #1244

Open

bwaidelich mentioned this pull request Nov 26, 2020

!!! TASK: Remove deprecated code #2262

Merged

mhsdesign mentioned this pull request Jan 30, 2024

TASK: Deprecate Flow's RequestInterface #3295

Closed

6 tasks

mhsdesign mentioned this pull request Feb 13, 2024

FEATURE: introduce UriHelper to work with query parameters #3316

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

!!!TASK: Remove deprecated Http objects and replace with PSR-7 implementation #1552

!!!TASK: Remove deprecated Http objects and replace with PSR-7 implementation #1552

albe commented Apr 19, 2019 •

edited by kitsunet

Loading

kitsunet commented Apr 26, 2019

albe commented Apr 28, 2019

kitsunet commented Apr 29, 2019 •

edited

Loading

albe left a comment

kitsunet May 5, 2019

albe May 12, 2019 •

edited

Loading

albe left a comment

kitsunet commented Aug 15, 2019

kitsunet left a comment

kitsunet commented Aug 16, 2019

!!!TASK: Remove deprecated Http objects and replace with PSR-7 implementation #1552

!!!TASK: Remove deprecated Http objects and replace with PSR-7 implementation #1552

Conversation

albe commented Apr 19, 2019 • edited by kitsunet Loading

kitsunet commented Apr 26, 2019

albe commented Apr 28, 2019

kitsunet commented Apr 29, 2019 • edited Loading

albe left a comment

Choose a reason for hiding this comment

kitsunet May 5, 2019

Choose a reason for hiding this comment

albe May 12, 2019 • edited Loading

Choose a reason for hiding this comment

albe left a comment

Choose a reason for hiding this comment

kitsunet commented Aug 15, 2019

kitsunet left a comment

Choose a reason for hiding this comment

kitsunet commented Aug 16, 2019

albe commented Apr 19, 2019 •

edited by kitsunet

Loading

kitsunet commented Apr 29, 2019 •

edited

Loading

albe May 12, 2019 •

edited

Loading